Skip to content

Maybe a bug in grpo_trainer.py #22

@Hui-design

Description

@Hui-design

Hi, thanks for your amazing work!
I've found that the inputs to 'get_per_token_logps' for model and ref_model are different, which might lead to a critical bug. This bug appears in R1-mulitimodal and Open-R1-Video. I've documented my understanding in this blog Hui-design/R1-Video-fixbug. Could you please review it to see if my understanding is correct?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions