[HOLD for payment 2025-01-02] [$250] Add "Workspace" to Profile and Name at the workspace level for clarity

[maddylewis]

Problem

The use of "Profile" at both the personal account level and at the workspace level. i was configuring the workspace settings, and seeing Profile > Name under the workspace almost prompted me to update that field with my own name (vs. the workspace name).

Solution

Add "Workspace" in front of all those. So:

• Workspace profile (LHN)
• Workspace profile (Page title)
• Workspace name (name field)

Super basic label updates in the first screenshot:

Second screenshot has the same label updates but also includes an icon and illustration update to tie into the visual language we typically use for workspaces:

---

Slack thread for additional context - https://expensify.slack.com/archives/C07NZ8B1VTQ/p1732116570767239

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866126703340321221
• Upwork Job ID: 1866126703340321221
• Last Price Increase: 2024-12-09
• Automatic offers:
• Krishna2323 | Contributor | 105260187

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Current assignee @dannymcclain is eligible for the Design assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-12-02 19:46:02 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add "Workspace" to Profile and Name at the workspace level for clarity

What is the root cause of that problem?

Improvement

What changes do you think we should make in order to solve the problem?

• Update the translation to Workspace Profile in both translation files.
  

  App/src/languages/en.ts

  Line 2475 in 473822d

  profile: 'Profile',

• Update these places to use workspace.common,workspaceName instead of workspace.editor.nameInputLabel.
  

  App/src/pages/workspace/WorkspaceProfilePage.tsx

  Line 206 in e28461b

  description={translate('workspace.editor.nameInputLabel')}

  
  

  App/src/pages/workspace/WorkspaceNamePage.tsx

  Line 70 in e28461b

  title={translate('workspace.editor.nameInputLabel')}

  
  

  App/src/pages/workspace/WorkspaceNamePage.tsx

  Lines 88 to 89 in e28461b

  	label={translate('workspace.editor.nameInputLabel')}
  	accessibilityLabel={translate('workspace.editor.nameInputLabel')}

• Update the new building illustration in illustration.ts or create new for building
  

  App/src/components/Icon/Illustrations.ts

  Line 99 in 473822d

  import House from '@assets/images/simple-illustrations/simple-illustration__house.svg';

  
  

  App/src/pages/workspace/WorkspaceProfilePage.tsx

  Line 157 in 473822d

  icon={Illustrations.House}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?


NA

What alternative solutions did you explore? (Optional)

[dannymcclain]

Since the building illustration in the page header is a new one, here's the exported SVG:

simple-illustration__building.svg.zip

[Krishna2323]

PROPOSAL UPDATED

• Pointed the files for illustration change.

[Krishna2323]

PROPOSAL UPDATED

• Updated main proposal to use existing workspace.common.workspaceName instead of workspace.editor.nameInputLabel.

[dannymcclain]

Not overdue Melv. We're just getting started here.

[maddylewis]

updated the K2 to Weekly as this is more of a polish item.

[Krishna2323]

@dannymcclain, are we ready to make this one external?

[dannymcclain]

Yeah I don't see why not!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021866126703340321221

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[dannymcclain]

Not sure if the bounty should be lower for this though. It seems like a pretty small change to me, but I'm not an engineer so maybe others can weigh in on that?

[Krishna2323]

@eh2077 @dannymcclain, PR is up for review^

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• improvement: Add "Workspace" to Profile and Name at the workspace level for clarity. #53800

If no regressions arise, payment will be issued on 2025-01-02. 🎊

For reference, here are some details about the assignees on this issue:

• @Krishna2323 requires payment automatic offer (Contributor)
• @eh2077 requires payment through NewDot Manual Requests

[melvin-bot]

@eh2077 @JmillsExpensify @eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@JmillsExpensify, @carlosmiceli, @dannymcclain, @Krishna2323, @eh2077 Huh... This is 4 days overdue. Who can take care of this?

[eh2077]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other: This is a new feature requested by the team.

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

No, we don't need a regression test here as it's straightforward UI feature.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

[eh2077]

Requested payment in NewDot

[JmillsExpensify]

Payment summary:

• Contributor: $250 @Krishna2323
• Reviewer: $250 @eh2077

[JmillsExpensify]

Also @Krishna2323 it looks like you need to accept the offer in Upwork.

[garrettmknight]

Payment summary:

• Contributor: $250 @Krishna2323
• Reviewer: $250 @eh2077

[JmillsExpensify]

$250 approved for @eh2077

[Krishna2323]

I've accepted the job offer 🤝

[carlosmiceli]

Not overdue.

[JmillsExpensify]

All paid out! Closing this issue.