[HOLD for payment 2025-01-02] Can't add new report actions in Debug mode

[DylanDylann]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Coming from #53027 (comment)

App/src/pages/Debug/ReportAction/DebugReportActionCreatePage.tsx

Line 117 in 3f4e93e

Debug.setDebugData(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`, {[parsedReportAction.reportActionID]: parsedReportAction});

we use the set method but we don't add the previous data. It caused when adding new report action, all previous report actions will be removed

cc @pac-guerreiro @puneetlath @JKobrynski

Issue Owner

Current Issue Owner: @DylanDylann

[Shahidullah-Muffakir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We are not keeping the old state in onyx

What is the root cause of that problem?

We are using set method of onyx, we should use merge

What changes do you think we should make in order to solve the problem?

here:

App/src/libs/actions/Debug.ts

Line 10 in 3baf965

function setDebugData<TKey extends OnyxKey | `${OnyxCollectionKey}${string}`>(onyxKey: TKey, onyxValue: OnyxMergeInput<TKey>) {

we can create one method for merge as well as:

function mergeDebugData<TKey extends OnyxKey | `${OnyxCollectionKey}${string}`>(onyxKey: TKey, onyxValue: OnyxMergeInput<TKey>) {
    Onyx.merge(onyxKey, onyxValue);
}

and then use it

[DylanDylann]

@pac-guerreiro or @JKobrynski will handle this issue. No require proposals

[JKobrynski]

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

[DylanDylann]

@JKobrynski Feel free to raise a PR

[puneetlath]

@JKobrynski do you have an ETA for a PR?

[pac-guerreiro]

@DylanDylann @puneetlath I'm back from my vacation so I'm taking this from @JKobrynski 😄

I'll raise a PR at the end of my work day 😄

[puneetlath]

Welcome back!