Can't add new report actions in Debug mode

[DylanDylann]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Coming from #53027 (comment)

App/src/pages/Debug/ReportAction/DebugReportActionCreatePage.tsx

Line 117 in 3f4e93e

Debug.setDebugData(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`, {[parsedReportAction.reportActionID]: parsedReportAction});

we use the set method but we don't add the previous data. It caused when adding new report action, all previous report actions will be removed

cc @pac-guerreiro @puneetlath @JKobrynski

Issue Owner

Current Issue Owner: @DylanDylann

[Shahidullah-Muffakir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We are not keeping the old state in onyx

What is the root cause of that problem?

We are using set method of onyx, we should use merge

What changes do you think we should make in order to solve the problem?

here:

App/src/libs/actions/Debug.ts

Line 10 in 3baf965

function setDebugData<TKey extends OnyxKey | `${OnyxCollectionKey}${string}`>(onyxKey: TKey, onyxValue: OnyxMergeInput<TKey>) {

we can create one method for merge as well as:

function mergeDebugData<TKey extends OnyxKey | `${OnyxCollectionKey}${string}`>(onyxKey: TKey, onyxValue: OnyxMergeInput<TKey>) {
    Onyx.merge(onyxKey, onyxValue);
}

and then use it

[DylanDylann]

@pac-guerreiro or @JKobrynski will handle this issue. No require proposals

[JKobrynski]

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

[DylanDylann]

@JKobrynski Feel free to raise a PR

[puneetlath]

@JKobrynski do you have an ETA for a PR?

[pac-guerreiro]

@DylanDylann @puneetlath I'm back from my vacation so I'm taking this from @JKobrynski 😄

I'll raise a PR at the end of my work day 😄

[puneetlath]

Welcome back!

[pac-guerreiro]

@puneetlath thanks! 😄

@DylanDylann I just opened a draft PR - #53969

I'll need to add screen recordings tomorrow!

If the PR is too big, I can split it in two 😉

[puneetlath]

Looks ok to me in terms of size, thanks!

[pac-guerreiro]

Today:

• Add testing steps
• Add screen recordings

Todo:

• Fix Not Found screen shown when navigating back after deleting a report

[pac-guerreiro]

@puneetlath @DylanDylann The PR is now ready for review! 😄

There's a minor issue where the Not Found page is shown if the user goes back after deleting a report. I'll look for a fix for this issue tomorrow!

[pac-guerreiro]

@DylanDylann @puneetlath

Last friday (12/13/24)

• I didn't have much time to focus on the remaining issue but I did some investigation and got some ideas to try

Today

• I tried some ideas and managed to find one that fixed the Not Found page showing after deleting a report, going to concierge and pressing back button on the header

[pac-guerreiro]

Waiting on @DylanDylann review 😄

[pac-guerreiro]

@puneetlath

@DylanDylann approved the PR 🥳 Feel free to chime in and let me know if there's anything that needs my attention 😄

[pac-guerreiro]

The PR was finally merged yesterday! 🥳

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.