Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-12-09 #53762

Closed
70 tasks done
github-actions bot opened this issue Dec 9, 2024 · 16 comments
Closed
70 tasks done

Deploy Checklist: New Expensify 2024-12-09 #53762

github-actions bot opened this issue Dec 9, 2024 · 16 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Release Version: 9.0.73-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@izarutskaya izarutskaya added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Dec 9, 2024
@MarioExpensify
Copy link
Contributor

Demoting #53768 (UI issue)

@amyevans
Copy link
Contributor

amyevans commented Dec 9, 2024

Demoted #53772

@tgolen
Copy link
Contributor

tgolen commented Dec 9, 2024

Demoted #53783

@mvtglobally
Copy link

mvtglobally commented Dec 10, 2024

Regression is at 80% completed

No Blockers, team is working on TC and PRs

@izarutskaya
Copy link

izarutskaya commented Dec 10, 2024

Regression is at 9% left.

PRs:
#52103 - Pending validation on Android and iOS
#52164 - Pending validation on Android
#52938 - failing with #52938 (comment). repro in Prod checking off
#53076 - Pending validation on iOS
#53108 - Found KI #53108 (comment)
#53198 - found KI #53198 (comment) Pending on iOS
#53203 - KI only on Web #53203 (comment)

DB:
#53819
#53822
#53823

@cristipaval
Copy link
Contributor

Demoting #53822 --> minor UI issue

@luacmartins luacmartins self-assigned this Dec 10, 2024
@luacmartins
Copy link
Contributor

luacmartins commented Dec 10, 2024

@mvtglobally @izarutskaya what's the status of regression?

@mvtglobally
Copy link

@luacmartins Wrapping last 1%

@luacmartins luacmartins added the Daily KSv2 label Dec 10, 2024
@mvtglobally
Copy link

mvtglobally commented Dec 10, 2024

Regression is completed.
Checking last CP

@luacmartins
Copy link
Contributor

@mvtglobally I see that the PRs below are still unchecked, are we still waiting on validation for them?

@mvtglobally
Copy link

mvtglobally commented Dec 10, 2024

Unchecked PRs
#52103 - is failing with KI #50796, #53833, and #53812
#53331 - Native app. KI: bug where the auth token is always empty(searching KI ID) . We are blocked on Android, but rest are pass

@luacmartins
Copy link
Contributor

Thanks! Let me know when you're done and I'll kick off the deploy if nothing else shows up.

@luacmartins
Copy link
Contributor

@mvtglobally are there any pending tasks on your end?

@mvtglobally
Copy link

mvtglobally commented Dec 10, 2024

No pending QA tasks.
You need to check those 2 PRs if they are good to go.

@luacmartins
Copy link
Contributor

Nice! In that case we're good to ship.

@luacmartins
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

8 participants