Icons are decolorized in security

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.78-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @allgandalf
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

1. Open settings > Security, > observe the icon on top left

Expected Result:

Icons are displayed in color

Actual Result:

Icons are decolorized in security

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.863.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[parasharrajat]

This PR #52823 caused this issue.

Here this line https://github.com/Expensify/App/pull/52823/files#diff-3ea703b86598917b6d2bd0c62d7489450ad5d73328aedb4596694419fcccc77eR185 we are now passing the default theme.icon to iconFill which overrides the color values.

[parasharrajat]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong color is shown for header icons.

What is the root cause of that problem?

We are not assigning a default value of theme.icon to all icons on Header via

App/src/components/HeaderWithBackButton/index.tsx

Line 185 in a088878

fill={iconFill ?? theme.icon}

.

THis change was added in #52823 to color TripDetails Page.

What changes do you think we should make in order to solve the problem?

1. We should remove the default value theme.icon from this prop at

   App/src/components/HeaderWithBackButton/index.tsx

   Line 185 in a088878

   fill={iconFill ?? theme.icon}

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[allgandalf]

Proposal makes sense to me 👍

[parasharrajat]

I created the PR based on approval from Slack.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[aldo-expensify]

Requested CP for #54514 here: https://expensify.slack.com/archives/C07J32337/p1735069519771039