[$250] Web - Blue selection border on plan option after a refresh

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.78-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 11 pro/chrome
App Component: Workspace Settings

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a workspace
3. Navigate to Workspace Settings > Profile > Plan
4. Refresh the page

Expected Result:

No border around a plan

Actual Result:

A blue selection on the selected plan after a refresh

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6701563_1735001860450.bandicam_2024-12-24_03-54-31-141.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021871677812777227550
• Upwork Job ID: 1871677812777227550
• Last Price Increase: 2024-12-24

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[DylanDylann]

I think we can demote this as a normal bug. This is a bug from SelectionList and It also happens on other selection list. Ex:

Screen.Recording.2024-12-24.at.17.06.22.mov

cc @jayeshmangwani

[jayeshmangwani]

Agreed @DylanDylann, it happens with other pages as well.

[cristipaval]

Demoting

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A blue selection on the selected plan after a refresh

What is the root cause of that problem?

We have the logic to focus the element programmatically in

App/src/components/SelectionList/BaseListItem.tsx

Line 49 in 8819d9c

useSyncFocus(pressableRef, !!isFocused, shouldSyncFocus);

App/src/hooks/useSyncFocus/index.ts

Line 23 in 8819d9c

ref.current?.focus();

The :focus-visible pseudo-class is triggered when the browser detects that focus was moved via an interaction that implies intent, such as keyboard navigation (Tab key) or assistive technology usage.

If users open the new page by clicking menu item, after focus, :focus-visible is not added since it's not focused by keyboard navigation.

but after refreshing page, browser somehow detects the previous users intent was keyboard interaction.

=> :focus-visible is applied

What changes do you think we should make in order to solve the problem?

At the first time the button render, if isFocused is true, we shouldn't sync focus since users haven't performed any action on that item.

We should sync focus when the isFocused changes from false to true (actual users interaction)

Here's the sample code

const shouldDisable = useRef(isFocused);

    useLayoutEffect(() => {
        if(shouldDisable && !isFocused){
            shouldDisable.current = false;
        }
        if (!isFocused || !shouldSyncFocus || !didScreenTransitionEnd || shouldDisable.current) {
            return;
        }

        ref.current?.focus();
...

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021871677812777227550

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)