-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$125] Chat - With quote markdown, url text on tapping enter key not moved to next line. #54522
Comments
Triggered auto assignment to @sakluger ( |
It is actually moved to next line due to link is considered a single word and there is not enough space to accommodate the link on same line. |
I tested myself in the iOS app and I saw different behavior from the video above. I tested with With With I also tested on MacOS chrome and could not reproduce. |
I'm going to set the bounty to $125 to start, hopefully this is a simple fix. |
Job added to Upwork: https://www.upwork.com/jobs/~021871675231934377672 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha ( |
Upwork job price has been updated to $125 |
ProposalPlease re-state the problem that we are trying to solve in this issue.With quote markdown, url text on tapping enter key not moved to next line. What is the root cause of that problem?We have the logic to throw the error if text !== markdown What changes do you think we should make in order to solve the problem?This PR removes What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?We should create the test for What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
I'm asking for the author the reason why he removed try/catch block: https://github.com/Expensify/react-native-live-markdown/pull/439/files#r1897091802 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.78-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Issue reported by: Applause Internal Team
Device used: Redmi note 10s Android 13
App Component: Chat Report View
Action Performed:
Expected Result:
With quote markdown, url text on tapping enter key must be moved to next line.
Actual Result:
With quote markdown, url text on tapping enter key not moved to next line.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6701644_1735017397193.Screenrecorder-2024-12-24-10-40-53-895_compress_1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @getushaThe text was updated successfully, but these errors were encountered: