Merge pull request #25 from Expensify/andrew-lint-fix

Fix bugs found with new eslint rule

Author: tgolen

.eslintrc.js

@@ -1,3 +1,3 @@
 module.exports = {
-    extends: './index.js'
+    extends: './index.js',
 }

index.js

@@ -1,4 +1,5 @@
 module.exports = {
+    plugins: ['@lwc/eslint-plugin-lwc'],
     extends: [
         'airbnb',
         require.resolve('./rules/style'),
@@ -11,6 +12,7 @@ module.exports = {
         jquery: true,
         node: true
     },
+    parser: 'babel-eslint',
     parserOptions: {
         ecmaVersion: 2018,
         sourceType: 'module',

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-expensify",
-  "version": "2.0.13",
+  "version": "2.0.15",
   "description": "Expensify's ESLint configuration following our style guide",
   "main": "index.js",
   "repository": {
@@ -9,6 +9,7 @@
   },
   "dependencies": {
     "@lwc/eslint-plugin-lwc": "^0.11.0",
+    "babel-eslint": "^10.1.0",
     "eslint": "6.8.0",
     "eslint-config-airbnb": "18.0.1",
     "eslint-config-airbnb-base": "14.0.0",

package.json

@@ -18,6 +18,6 @@ module.exports = {
         }],
 
         // Do not allow the use of async/await
-        'lwc/no-async-await': 'error',
+        '@lwc/lwc/no-async-await': 'error',
     }
 };

rules/es6.js

@@ -19,9 +19,9 @@ module.exports = {
         'react/forbid-prop-types': 'error',
         'react/no-string-refs': 'error',
 
-        // Rather then blindly enforcing destructuring assignments, we'll trust the author's best judgement on when
-        // to make use of them, and when not; see https://github.com/Expensify/Style-Guide/pull/60 for more details
-        'react/destructuring-assignment': 'warn',
+        // Do not warn or error for destructuring
+        // See: https://github.com/Expensify/Style-Guide/blob/master/javascript.md#destructuring
+        'react/destructuring-assignment': 'off',
 
         // New versions of react are removing some methods, and those methods have been prefixed with "UNSAFE_" for now.
         // We need to prevent more usages of these methods and their aliases from being added