Add Android Google Wallet module #5

Skalakid · 2025-01-09T15:06:33Z

Details

This PR adds the Android Google Wallet module. Based on @zfurtak POC

Related Issues

GH_LINK

Manual Tests

Linked PRs

* npx create-react-native-library react-native-wallet * Update CONTRIBUTING.md * Add CLA.md * Update package.jsons * Update eslint rules * Migrate yarn to npm * Update README * Update lint.yml * Update lefthook.yml * Add old arch backward compatibility * Fix eslint * Fix iOS structure for both Fabric and Paper * Add platform info to example app * Update Podfile.lock * Update publish.yml * Update package.json * Change MainActivity and MainApplication location * Update xCode scheme * Fix ESlint and Prettier * Remove unnecessary support for very old versions * Downgrafe @react-native/eslint-config * Remove web from PlatformInfo * Add Android review changes * Update package description * Add gitignore to the example app * Add iOS review changes * Remove tests * Change Wallet Specs * Add javaPackageName * Update RN to 0.76 * Remove comment * Remove react-native.config.js * Update Podfile.lock * Change package name to include expensify in it * Add review changes * Add newline

brunovjk · 2025-01-22T12:24:25Z

react-native-wallet/README.md

Line 27 in 9baa0bf

    
           Right now, contributions to this library are done under https://github.com/Expensify/App. Please refer to that repo and all it's guidelines for contributing.w.

Hi, is the .w at the end of the sentence in the README a typo? Thanks! Oops, I don't know if this is the best place to ask this—sorry!

Skalakid · 2025-01-22T14:09:04Z

@brunovjk Yes, it was a typo, good catch thank you :D

github-actions · 2025-01-27T18:06:42Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

zfurtak · 2025-01-27T18:07:17Z

I have read the CLA Document and I hereby sign the CLA

zfurtak

The PR looks awesome 🤩🎉 I left a couple of thoughts to discuss 😉

android/src/main/java/com/expensify/wallet/WalletModule.kt

android/src/main/java/com/expensify/wallet/model/CardStatus.kt

android/src/main/java/com/expensify/wallet/WalletModule.kt

android/src/main/java/com/expensify/wallet/Utils.kt

WoLewicki

Good job! I added some comments.

README.md

android/src/main/java/com/expensify/wallet/WalletModule.kt

ios/Wallet.mm

* Link Google TapAndPay SDK to the library * Add checkWalletAvailability function * Update example app * Add getSecureWalletInfo function * Update example app * Move getWalletId function * Add getCardStatus function * Add getCardStatus example * Add getCardTokenStatus function * Add getCardTokenStatus example * Add addCardToWallet function * Add addCardToWallet example * Add onCardActivated event listener * Set up the repo structure (#4) * npx create-react-native-library react-native-wallet * Update CONTRIBUTING.md * Add CLA.md * Update package.jsons * Update eslint rules * Migrate yarn to npm * Update README * Update lint.yml * Update lefthook.yml * Add old arch backward compatibility * Fix eslint * Fix iOS structure for both Fabric and Paper * Add platform info to example app * Update Podfile.lock * Update publish.yml * Update package.json * Change MainActivity and MainApplication location * Update xCode scheme * Fix ESlint and Prettier * Remove unnecessary support for very old versions * Downgrafe @react-native/eslint-config * Remove web from PlatformInfo * Add Android review changes * Update package description * Add gitignore to the example app * Add iOS review changes * Remove tests * Change Wallet Specs * Add javaPackageName * Update RN to 0.76 * Remove comment * Remove react-native.config.js * Update Podfile.lock * Change package name to include expensify in it * Add review changes * Add newline * Update package name in kotlin files * Update Promise object interface methods * Update README * Fix app crashing when SDK is not verified * Unify error handling in the WalletModule * Move OnCardActivatedEvent file and update its name * Add InvalidNetworkError * Add SDK intructions to README * Add whitelisting intructions to README * Add beta tests intructions to README * Update step 3 in README * Update README * Update README * Adjust PR * Implement missing function and adjust the code * Adjust PR to comments * Change init to initialize * Fix not null assertion on currentActivity * Add removeActivityEventListener on module invalidation --------- Co-authored-by: zfurtak <[email protected]>

Add checkWalletAvailability function Update example app Add getSecureWalletInfo function Update example app Move getWalletId function Add getCardStatus function Add getCardStatus example Add getCardTokenStatus function Add getCardTokenStatus example Add addCardToWallet function Add addCardToWallet example Add onCardActivated event listener Set up the repo structure (#4) * npx create-react-native-library react-native-wallet * Update CONTRIBUTING.md * Add CLA.md * Update package.jsons * Update eslint rules * Migrate yarn to npm * Update README * Update lint.yml * Update lefthook.yml * Add old arch backward compatibility * Fix eslint * Fix iOS structure for both Fabric and Paper * Add platform info to example app * Update Podfile.lock * Update publish.yml * Update package.json * Change MainActivity and MainApplication location * Update xCode scheme * Fix ESlint and Prettier * Remove unnecessary support for very old versions * Downgrafe @react-native/eslint-config * Remove web from PlatformInfo * Add Android review changes * Update package description * Add gitignore to the example app * Add iOS review changes * Remove tests * Change Wallet Specs * Add javaPackageName * Update RN to 0.76 * Remove comment * Remove react-native.config.js * Update Podfile.lock * Change package name to include expensify in it * Add review changes * Add newline Update package name in kotlin files Update Promise object interface methods Update README Fix app crashing when SDK is not verified Unify error handling in the WalletModule Move OnCardActivatedEvent file and update its name Add InvalidNetworkError Add SDK intructions to README Add whitelisting intructions to README Add beta tests intructions to README Update step 3 in README Update README Update README Adjust PR Implement missing function and adjust the code Adjust PR to comments Change init to initialize Add button component Add google path map Final version Update README Update example app Remove imageStyle Texst Change assets to svg ones Add button with svg image Fix not null assertion on currentActivity Adjusted to review comments Add new line in package.json Add Android Google Wallet module (#5) * Link Google TapAndPay SDK to the library * Add checkWalletAvailability function * Update example app * Add getSecureWalletInfo function * Update example app * Move getWalletId function * Add getCardStatus function * Add getCardStatus example * Add getCardTokenStatus function * Add getCardTokenStatus example * Add addCardToWallet function * Add addCardToWallet example * Add onCardActivated event listener * Set up the repo structure (#4) * npx create-react-native-library react-native-wallet * Update CONTRIBUTING.md * Add CLA.md * Update package.jsons * Update eslint rules * Migrate yarn to npm * Update README * Update lint.yml * Update lefthook.yml * Add old arch backward compatibility * Fix eslint * Fix iOS structure for both Fabric and Paper * Add platform info to example app * Update Podfile.lock * Update publish.yml * Update package.json * Change MainActivity and MainApplication location * Update xCode scheme * Fix ESlint and Prettier * Remove unnecessary support for very old versions * Downgrafe @react-native/eslint-config * Remove web from PlatformInfo * Add Android review changes * Update package description * Add gitignore to the example app * Add iOS review changes * Remove tests * Change Wallet Specs * Add javaPackageName * Update RN to 0.76 * Remove comment * Remove react-native.config.js * Update Podfile.lock * Change package name to include expensify in it * Add review changes * Add newline * Update package name in kotlin files * Update Promise object interface methods * Update README * Fix app crashing when SDK is not verified * Unify error handling in the WalletModule * Move OnCardActivatedEvent file and update its name * Add InvalidNetworkError * Add SDK intructions to README * Add whitelisting intructions to README * Add beta tests intructions to README * Update step 3 in README * Update README * Update README * Adjust PR * Implement missing function and adjust the code * Adjust PR to comments * Change init to initialize * Fix not null assertion on currentActivity * Add removeActivityEventListener on module invalidation --------- Co-authored-by: zfurtak <[email protected]>

* Link Google TapAndPay SDK to the library * Add checkWalletAvailability function * Update example app * Add getSecureWalletInfo function * Update example app * Move getWalletId function * Add getCardStatus function * Add getCardStatus example * Add getCardTokenStatus function * Add getCardTokenStatus example * Add addCardToWallet function * Add addCardToWallet example * Add onCardActivated event listener * Set up the repo structure (#4) * npx create-react-native-library react-native-wallet * Update CONTRIBUTING.md * Add CLA.md * Update package.jsons * Update eslint rules * Migrate yarn to npm * Update README * Update lint.yml * Update lefthook.yml * Add old arch backward compatibility * Fix eslint * Fix iOS structure for both Fabric and Paper * Add platform info to example app * Update Podfile.lock * Update publish.yml * Update package.json * Change MainActivity and MainApplication location * Update xCode scheme * Fix ESlint and Prettier * Remove unnecessary support for very old versions * Downgrafe @react-native/eslint-config * Remove web from PlatformInfo * Add Android review changes * Update package description * Add gitignore to the example app * Add iOS review changes * Remove tests * Change Wallet Specs * Add javaPackageName * Update RN to 0.76 * Remove comment * Remove react-native.config.js * Update Podfile.lock * Change package name to include expensify in it * Add review changes * Add newline * Update package name in kotlin files * Update Promise object interface methods * Update README * Fix app crashing when SDK is not verified * Unify error handling in the WalletModule * Move OnCardActivatedEvent file and update its name * Add InvalidNetworkError * Add SDK intructions to README * Add whitelisting intructions to README * Add beta tests intructions to README * Update step 3 in README * Update README * Update README * Adjust PR * Implement missing function and adjust the code * Adjust PR to comments * Change init to initialize * Fix not null assertion on currentActivity * Add removeActivityEventListener on module invalidation --------- Add Add to wallet button (#6) * Add button component * Add google path map * Update README * Change assets to svg ones * Add button with svg image * Adjusted to review comments --------- Co-authored-by: zfurtak <[email protected]>

Skalakid changed the base branch from main to @Skalakid/set-up-repo January 9, 2025 15:06

This was referenced Jan 10, 2025

[$1500] Create new library and native module react-native-wallet Expensify/App#36957

Closed

Set up the repo structure #4

Merged

Skalakid changed the base branch from @Skalakid/set-up-repo to main January 22, 2025 11:31

Skalakid changed the base branch from main to @Skalakid/set-up-repo January 22, 2025 11:31

Base automatically changed from @Skalakid/set-up-repo to main January 22, 2025 11:35

Skalakid and others added 14 commits January 22, 2025 12:53

Link Google TapAndPay SDK to the library

72724af

Add checkWalletAvailability function

b564b6b

Update example app

8daf16e

Add getSecureWalletInfo function

110f1cc

Update example app

a4f648b

Move getWalletId function

64ce539

Add getCardStatus function

4ba3cc8

Add getCardStatus example

ff8ed4f

Add getCardTokenStatus function

d9fbff1

Add getCardTokenStatus example

465da22

Add addCardToWallet function

b30cd26

Add addCardToWallet example

5a6c3c2

Add onCardActivated event listener

41248d1

Skalakid force-pushed the @Skalakid/android-module branch from 7dfab27 to 1ce871d Compare January 22, 2025 11:58

Skalakid added 3 commits January 22, 2025 15:06

Update package name in kotlin files

ab55ce1

Update Promise object interface methods

c325953

Update README

6e5b033

Fix app crashing when SDK is not verified

dcc4c4d

Skalakid force-pushed the @Skalakid/android-module branch from ad063ed to dcc4c4d Compare January 23, 2025 12:05

Skalakid added 2 commits January 23, 2025 14:37

Unify error handling in the WalletModule

65b3f1a

Move OnCardActivatedEvent file and update its name

cf1376a

Add InvalidNetworkError

d94a874

Skalakid requested a review from zfurtak January 24, 2025 15:11

Skalakid and others added 5 commits January 27, 2025 10:36

Add SDK intructions to README

a542747

Add whitelisting intructions to README

fd4f48d

Add beta tests intructions to README

b759470

Update step 3 in README

2deac8e

Update README

5f95913

Update README

0b61497

zfurtak reviewed Jan 28, 2025

View reviewed changes

zfurtak added 2 commits January 28, 2025 22:33

Adjust PR

c2162c9

Implement missing function and adjust the code

bf30bb7

WoLewicki reviewed Jan 29, 2025

View reviewed changes

Adjust PR to comments

c66fe3c

Skalakid requested a review from WoLewicki February 12, 2025 12:16

Skalakid marked this pull request as ready for review February 12, 2025 12:18

WoLewicki approved these changes Feb 12, 2025

View reviewed changes

zfurtak and others added 3 commits February 12, 2025 13:42

Change init to initialize

56677a2

Fix not null assertion on currentActivity

c408e93

Add removeActivityEventListener on module invalidation

ecb30a9

Skalakid force-pushed the @Skalakid/android-module branch from cc2e044 to ecb30a9 Compare February 12, 2025 12:42

Skalakid merged commit 270be84 into main Feb 12, 2025
2 checks passed

zfurtak mentioned this pull request Feb 18, 2025

Add Android Google Wallet integration #7

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Android Google Wallet module #5

Add Android Google Wallet module #5

Uh oh!

Skalakid commented Jan 9, 2025 •

edited

Loading

Uh oh!

brunovjk commented Jan 22, 2025 •

edited

Loading

Uh oh!

Skalakid commented Jan 22, 2025

Uh oh!

github-actions bot commented Jan 27, 2025 •

edited

Loading

Uh oh!

zfurtak commented Jan 27, 2025

Uh oh!

zfurtak left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WoLewicki left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Add Android Google Wallet module #5

Add Android Google Wallet module #5

Uh oh!

Conversation

Skalakid commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Related Issues

Manual Tests

Linked PRs

Uh oh!

brunovjk commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Skalakid commented Jan 22, 2025

Uh oh!

github-actions bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zfurtak commented Jan 27, 2025

Uh oh!

zfurtak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WoLewicki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Skalakid commented Jan 9, 2025 •

edited

Loading

brunovjk commented Jan 22, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading