Clean up

Cleaned the code a bit, removed console logs and comments. Also removed the "hh:mm:ss" format check in getSkipOffsetValue function in vast-maker.js.
Eyevinn · Jun 19, 2024 · fc7cb85 · fc7cb85
1 parent b5ee9c7
commit fc7cb85
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/utils/vast-maker.js b/utils/vast-maker.js
@@ -86,7 +86,6 @@ const DEFAULT_AD_LIST = [
  * 
  */
 function VastBuilder(params) {
-  console.log("VastBuilder params: ", params);
   let vastObject = {};
   let adList = [];
   let vast = null;
@@ -352,16 +351,13 @@ function indexOfSmallest(a) {
   return lowest;
 }
 
-// Validate that params.skipoffset is a valid VAST skipoffset value ("x%" or "hh:mm:ss").
 function getSkipOffsetValue(skipoffset) {
-  // "hh:mm:ss"
-  const timeFormatRegex = /^(\d{2}):([0-5][0-9]):([0-5][0-9])$/;
   // "x%"
   const percentageFormatRegex = /^(100|[1-9]?[0-9])%$/;
   // "seconds"
   const integerSecondsRegex = /^\d+$/;
 
-  if (timeFormatRegex.test(skipoffset) || percentageFormatRegex.test(skipoffset)){
+  if (percentageFormatRegex.test(skipoffset)){
     return skipoffset;
   } 
   // convert seconds to "hh:mm:ss" format

diff --git a/utils/vmap-maker.js b/utils/vmap-maker.js
@@ -91,7 +91,6 @@ function VmapBuilder(params) {
 
   const breakpoints = params.breakpoints ? params.breakpoints.split(",").filter((item) => !isNaN(Number(item))) : [];
   if (params.preroll) {
-    //console.log("PARAMS: ",params.generalVastConfigs);
     const preVast = VastBuilder(defaultConfigs);
     vmap.attachAdBreak("preroll.ad", "linear", "start", preVast.xml, {
       sessionId: GVC.sessionId,