Skip to content

Commit a409585

Browse files
committed
Fix minor things noticed by review
1 parent f62fd2e commit a409585

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

src/fa/maps.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ def processMapFolderForUpload(mapDir: str) -> None:
404404
if sum([filename.endswith(x) for x in endings]) > 0:
405405
files.append(os.path.join(mapDir, filename))
406406

407-
temp = tempfile.NamedTemporaryFile(mode='w+b', suffi=".zip", delete=False)
407+
temp = tempfile.NamedTemporaryFile(mode='w+b', suffix=".zip", delete=False)
408408

409409
# creating the zip
410410
zipped = zipfile.ZipFile(temp, "w", zipfile.ZIP_DEFLATED)

src/replays/replaydetails/replaycard.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,6 @@ def on_download_finished(self, reply: QtNetwork.QNetworkReply) -> None:
244244
reply.deleteLater()
245245

246246
def show_about(self) -> None:
247-
# flags = QtCore.Qt.WindowType.WindowTitleHint | QtCore.Qt.WindowType.WindowSystemMenuHint
248247
about = QtWidgets.QDialog(None, QtCore.Qt.WindowType.Widget)
249248
about.setWindowTitle("About")
250249
aboutText = (

src/replays/zigparser/converter.zig

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,10 +221,10 @@ pub fn convert_chart_data(replay_parser: parser.Parser) [*c]py.PyObject {
221221
}
222222

223223
pub fn convert_gamestats(replay_parser: parser.Parser) [*c]py.PyObject {
224-
if (replay_parser.body_data.game_stats == null) {
225-
return py.Py_BuildValue("");
224+
if (replay_parser.body_data.game_stats) |game_stats| {
225+
return convert_object(game_stats.value);
226226
}
227-
return convert_object(replay_parser.body_data.game_stats.?.value);
227+
return py.Py_BuildValue("");
228228
}
229229

230230
pub fn convert_header(replay_parser: parser.Parser) [*c]py.PyObject {

src/vaults/starrating.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ def __init__(
3232
self.star_color_filled = star_color_filled
3333
self.star_color_empty = Qt.GlobalColor.black
3434

35-
# Set widget size
3635
self.setFixedSize(self.max_rating * self.star_size, self.star_size)
3736

3837
def paintEvent(self, event: QPaintEvent | None) -> None:

0 commit comments

Comments
 (0)