Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Map Generation fails for some combinations of Number of Teams and Symmetry type #3273

Open
obydog002 opened this issue Nov 15, 2024 · 3 comments
Labels

Comments

@obydog002
Copy link
Contributor

obydog002 commented Nov 15, 2024

Describe the Bug

generation

With a configuration like the above the map generation fails silently.

Log file or Error Message

Silently fails

Reproduce the bug

Some combinations I tried that dont work:

  • 2 teams, POINT5 symmetry
  • 3 teams, POINT5 symmetry
  • 4 teams, POINT3 symmetry
  • 4 teams, POINT2 symmetry

Expected Behavior

Granted I don't expect for example 2 teams with 5 symmetry to generate a balanced map, so if its impossible the map gen dialog should disable the 'incompatible' options or disappear them, similar to how Spawns and Teams are linked. But I cant see why for example 4 teams, POINT2 symmetry shouldn't work

If they should be generating then the underlying issue should be fixed. I'd prefer they generate even if results in a unbalanced map.

Screenshots

No response

Additional context

No response

Which Operating System are you using?

Linux

@obydog002 obydog002 added the bug label Nov 15, 2024
@obydog002 obydog002 changed the title [Bug]: Map Generation with coprime symmetry and number of teams fails [Bug]: Map Generation fails for some combinations of Number of Teams and Symmetry type Nov 15, 2024
@Sheikah45
Copy link
Member

The map generator can only generate maps when the number of teams is a factor of the number of symmetry points.

Really the symmetry setting is an advanced option that shouldn't really be shown by default because of this.

@obydog002
Copy link
Contributor Author

Yea, makes sense. Too bad for the 3 teams 7 symmetry maps XD

Then its okay if it would just disable or remove the options if they are incompatible.

@Sheikah45
Copy link
Member

Sheikah45 commented Nov 15, 2024

The issue is that the client only knows the name of the symmetries not their compatibility with the number of teams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants