Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAMAS import fails for data processed in casa using range calibration. #62

Closed
sameyley opened this issue Jun 15, 2024 · 5 comments · Fixed by #63
Closed

VAMAS import fails for data processed in casa using range calibration. #62

sameyley opened this issue Jun 15, 2024 · 5 comments · Fixed by #63
Assignees
Labels
bug Something isn't working

Comments

@sameyley
Copy link

Trying to import vamas files which were calibrated using range calibration fails due to

align.measured_energy = float(split_line[measured_index + 2])
.

The line in the vamas file in these cases is e.g.:

Calib M = 280,281 A = 285 BE ADD

@lukaspie lukaspie added the bug Something isn't working label Jun 18, 2024
@lukaspie lukaspie self-assigned this Jun 18, 2024
@lukaspie
Copy link
Collaborator

Dear @sameyley, thanks for testing out the reader with your data! I think I pretty much know what the problem is and will implement a fix relatively soon. I will let you know as soon as it is fixed. If you want, you could share one of your files with me so I can make sure that there won't be any other problems.

Note however, that the parsing of data processing from CasaXPS was only recently introduced and is still somewhat experimental. We are still working on updating our description of fitting in general (see FAIRmat-NFDI/nexus_definitions#170 for the discussion on the data modeling), so this will probably still change a bit.

@sameyley
Copy link
Author

Hi Lukas,
Here is a test file: test_data.zip. We also use a Kratos instrument, so this could also be useful for #61.

@ondracka
Copy link

ondracka commented Jun 20, 2024

@sameyley off topic here, but would you be willing to share your KRATOS ELN file?

@sameyley
Copy link
Author

@sameyley off topic here, but would you be willing to share your KRATOS ELN file?

I don't have one, sorry - just like you, I just tried importing the data without setting up an ELN. I doubt I will do one for now as my workflow is centred around VAMAS file format and I see that there are lots of parameters for nxmpes for which I do not have an answer at the moment. It's not a priority, I was just curious after seeing Lukas' presentation at ECASIA.

@ondracka
Copy link

I see, thanks. Yeah, I think it will be some work to get the ELN just right... unless I can catch some KRATOS technician when the next maintenance time comes 😄

@lukaspie lukaspie linked a pull request Jun 26, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants