Skip to content

Commit b172e62

Browse files
Remove IrreducibleInt (#702)
* remove irreducible int * ufl branch * update DOLFINx demo running * CI fix * main UFL --------- Co-authored-by: Garth N. Wells <[email protected]>
1 parent dbf4a73 commit b172e62

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

.github/workflows/dolfin-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ jobs:
8686
8787
- name: Build DOLFINx C++ unit tests
8888
run: |
89-
cmake -G Ninja -DCMAKE_BUILD_TYPE=Developer -B build/test/ -S build/test/
89+
cmake -G Ninja -DCMAKE_BUILD_TYPE=Developer -B build/test/ -S dolfinx/cpp/test/
9090
cmake --build build/test
9191
- name: Run DOLFINx C++ unit tests
9292
run: |

python/basix/ufl.py

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
import numpy.typing as _npt
1212
import ufl as _ufl
1313
# TODO: remove gdim arguments once UFL handles cells better
14-
# TODO: remove IrreducibleInt once UFL handles element degrees better
15-
from ufl.algorithms.estimate_degrees import IrreducibleInt as _IrreducibleInt
1614
from ufl.finiteelement import FiniteElementBase as _FiniteElementBase
1715

1816
import basix as _basix
@@ -51,7 +49,7 @@ class _ElementBase(_FiniteElementBase):
5149
"""
5250

5351
def __init__(self, repr: str, name: str, cellname: str, value_shape: _typing.Tuple[int, ...],
54-
degree: _typing.Union[int, _IrreducibleInt] = -1, mapname: _typing.Optional[str] = None,
52+
degree: int = -1, mapname: _typing.Optional[str] = None,
5553
gdim: _typing.Optional[int] = None):
5654
"""Initialise the element."""
5755
super().__init__(name, _ufl.cell.Cell(cellname, gdim), degree, None, value_shape, value_shape)
@@ -342,15 +340,9 @@ def __init__(self, element: _basix.finite_element.FiniteElement, gdim: _typing.O
342340
repr = (f"Basix element ({element.family.name}, {element.cell_type.name}, {element.degree}, "
343341
f"{element.lagrange_variant.name}, {element.dpc_variant.name}, {element.discontinuous})")
344342

345-
if element.cell_type.name in ["interval", "triangle", "tetrahedron"]:
346-
super().__init__(
347-
repr, element.family.name, element.cell_type.name, tuple(element.value_shape), element.degree,
348-
_map_type_to_string(element.map_type), gdim=gdim)
349-
else:
350-
# TODO: remove IrreducibleInt once UFL handles element degrees better
351-
super().__init__(
352-
repr, element.family.name, element.cell_type.name, tuple(element.value_shape),
353-
_IrreducibleInt(element.degree), _map_type_to_string(element.map_type), gdim=gdim)
343+
super().__init__(
344+
repr, element.family.name, element.cell_type.name, tuple(element.value_shape), element.degree,
345+
_map_type_to_string(element.map_type), gdim=gdim)
354346

355347
self.element = element
356348

0 commit comments

Comments
 (0)