Skip to content

Error in GoBildaPinpointDriver, setEncoderResolution method #1654

@jkenney2

Description

@jkenney2

The setEncoderResolution(double ticksPerUnit, DistanceUnit distanceUnit) method calculates the resolution (in ticks/mm) as follows:

resolution = distanceUnit.toMm(ticksPerUnit);

The problem is resolution is not a distance, it is ticks Per distance, so using the distanceUnit.toMm method directly on ticksPerUnit does not work as desired. This could be corrected as follows:

resolution = 1.0 / distanceUnit.toMm(1.0 / ticksPerUnit);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions