Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync blocks after loan migration #788

Open
banerjek opened this issue Aug 2, 2024 · 5 comments
Open

Sync blocks after loan migration #788

banerjek opened this issue Aug 2, 2024 · 5 comments
Labels
loans Tool enhancements New feature or request

Comments

@banerjek
Copy link
Member

banerjek commented Aug 2, 2024

A huge percentage of the time, the loan migration process ends with a lot of spurious blocks that must be cleared via a call to /automated-patron-blocks/synchronization/job

This happens often enough that seems worthwhile to just automatically launch this after a loans migration process

@bltravis
Copy link
Collaborator

bltravis commented Aug 5, 2024

@banerjek Launch and continue, or launch and wait?

@banerjek
Copy link
Member Author

banerjek commented Aug 5, 2024

Launch and continue -- I wouldn't bother to monitor/verify it.

If it failed for some reason and there were affected users, manual intervention would be necessary anyway. No need to add additional overhead

@bltravis
Copy link
Collaborator

bltravis commented Aug 7, 2024

I will note that this can be an "expensive" process, depending on how many transactions are present in the system.

@banerjek
Copy link
Member Author

banerjek commented Aug 7, 2024

I really hated having to suggest this enhancement for precisely that reason, but unfortunately my experience is the number of transactions correlates strongly with improper autoblocks

I have theories that this is more a function of the nature of the transactions that we get when someone sends tens of thousands (or a quarter million as I recently migrated), but the end effect is the same, namely that loan migrations are resulting in autoblocked users so often (and these are inevitably the heaviest users) that I've been needing to do this basically every time

@bltravis
Copy link
Collaborator

Automated patron blocks rely on mod-pubsub, which does not have any form of delivery guarantee for published messages. For automated transaction migrations, I suspect the event queue is being overwhelmed.

btravisebsco pushed a commit that referenced this issue Aug 20, 2024
…on and method for syncing patron blocks. Call in wrap-up method.
@bltravis bltravis added Tool enhancements New feature or request loans labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loans Tool enhancements New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants