bgpd: Treat the peer as not active due to BFD down only if established

ton31337 · ton31337 · commit da4a7b0356fa · 2025-04-02T17:24:09.000+03:00
If we have `neighbor X bfd` and BFD status is DOWN and/or ADMIN_DOWN, and BGP session is not yet established, we never allow the session to establish. Let's fix this regression that was in 10.2. Fixes: 1fb48f5 ("bgpd: Do not start BGP session if BFD profile is in shutdown state") Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
diff --git a/bgpd/bgpd.c b/bgpd/bgpd.c
@@ -4789,7 +4789,7 @@ enum bgp_peer_active peer_active(struct peer_connection *connection)
 		return BGP_PEER_CONNECTION_UNSPECIFIED;
 
 	if (peer->bfd_config) {
-		if (bfd_session_is_down(peer->bfd_config->session))
+		if (peer_established(connection) && bfd_session_is_down(peer->bfd_config->session))
 			return BGP_PEER_BFD_DOWN;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -4789,7 +4789,7 @@ enum bgp_peer_active peer_active(struct peer_connection *connection)`
`4789`	`4789`	`return BGP_PEER_CONNECTION_UNSPECIFIED;`
`4790`	`4790`
`4791`	`4791`	`if (peer->bfd_config) {`
`4792`		`- if (bfd_session_is_down(peer->bfd_config->session))`
	`4792`	`+ if (peer_established(connection) && bfd_session_is_down(peer->bfd_config->session))`
`4793`	`4793`	`return BGP_PEER_BFD_DOWN;`
`4794`	`4794`	`}`
`4795`	`4795`