Accessors/Invokers should ignore `modid$` prefixes

[sylv256]

@Accessor/@invoker methods should ignore modid$ prefixes when automatically finding target methods using set, get, and invoke. This is for convenience and compatibility at the same time.

Before

@Mixin(MyClass.class)
public interface MyClassAccess {
  @Invoker void invokeAccess();
  @Accessor int getMyField();
}

or

@Mixin(MyClass.class)
public interface MyClassAccess {
  @Invoker("access")
  void modid$invokeAccess();

  @Accessor("myField")
  int modid$getMyField();
}

After

@Mixin(MyClass.class)
public interface MyClassAccess {
  @Invoker void modid$invokeAccess();
  @Accessor int modid$getMyField();
}

[Gamebuster19901]

I think this is a bad idea. You can't reliably tell if something is a modid or if the field/method actually has a $ character. For example, enums are known to have $ characters in openjdk.

Both @invoker and @Accessor can specify what method to target using a string value.

I believe in most (all?) instances you won't need to prefix your modid in an accessor/invoker anyway. Maybe if your mod has another mixin that adds a method... but you should already have access to it if that was the case.

Also, a mixin may want to access/invoke something added by a mixin from another mod. This would break that.

[cputnam-a11y]

I believe in most (all?) instances you won't need to prefix your modid in an accessor/invoker anyway. Maybe if your mod has another mixin that adds a method... but you should already have access to it if that was the case.

See the massive conversation that sparked this:
https://discord.com/channels/507304429255393322/807617284129423370/1385791802778583220
FabricMC/community#182

[sylv256]

I believe in most (all?) instances you won't need to prefix your modid in an accessor/invoker anyway. Maybe if your mod has another mixin that adds a method... but you should already have access to it if that was the case.

Actually, it's been brought up that in the case of a Mojang method having the same signature, it could be problematic.

[Earthcomputer]

If a Mojang method has the same signature, then either that's the getter you should be using over the accessor, or in the rare instance it's not actually a simple getter, then you have the option of renaming the accessor, but that is an extremely rare corner case that shouldn't have this level of special handling in Mixin