Skip to content

Mappings on single-jar legacy versions broken due to force-enabling split official namespaces #1360

@Juuxel

Description

@Juuxel

(Loom 1.11.7 on Gradle 9.0.0)

When targeting MC 0.30, Loom incorrectly uses the clientOfficial and serverOfficial namespaces of legacy merged versions despite 0.30 having no server jar. This means that mappings that use the correct official namespace no longer work, despite working in previous 1.x versions such as 1.5.

The clientOfficial and serverOfficial namespaces should not exist when there's only one environment available to begin with.

The specific issue that caused mappings to stop working was not adding those namespaces since namespace completion filled in the blanks. The bug was "fully" added in #1171 which stopped unwanted ns completion on split official ns versions to prevent mapping conflicts.

Reproducer (see the two branches on that repo): https://github.com/Juuxel/classic-mappings-reproducer

I can confirm from local testing that applying this patch to completely disable the merged namespace system single-jar envs with no intermediate mappings works.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions