Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete test review #6

Open
AdamSLevy opened this issue Sep 11, 2019 · 0 comments
Open

Complete test review #6

AdamSLevy opened this issue Sep 11, 2019 · 0 comments
Milestone

Comments

@AdamSLevy
Copy link
Collaborator

AdamSLevy commented Sep 11, 2019

A complete review of the existing tests should be done to ensure:

  • Appropriate levels of test coverage for all areas of the code. Note that this does not by any means specify a specific % level of coverage. In fact 100% is too much. The package is coded defensively, which means a lot of code paths are difficult to reach. Don't bend over backward to get coverage through every if err != nil { branch when that error is very unlikely.
  • Clarity of tests
  • Consistency and reduction of runtime dependencies.
  • Integration and Unit test distinction. Many of the tests actually query factomd, making them an integration test. So allow test control with use of flags (if a test needs to hit an API, allow that to be skipped).
@AdamSLevy AdamSLevy added this to the v1 milestone Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant