Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap all factomd API calls with automated retries #30

Open
AdamSLevy opened this issue Sep 11, 2019 · 0 comments
Open

Wrap all factomd API calls with automated retries #30

AdamSLevy opened this issue Sep 11, 2019 · 0 comments
Labels
enhancement New feature or request fatd

Comments

@AdamSLevy
Copy link
Collaborator

Implement a consistent retry mechanism on all factomd API calls in engine.
Exponential backoff with some sane limits should be used. This package is recommended: https://github.com/cenkalti/backoff

Retries should only occur if we get back a 500 server error. At least one successful attempt to hit the factomd API should be required. So don't retry during initial setup in the engine.Start function.

Errors should be logged and the next retry time should be printed.

The -factomscanretries flag should be renamed but we should still have a similar flag.

A context should be used so that stop signals are responded to.

@AdamSLevy AdamSLevy added enhancement New feature or request fatd labels Sep 11, 2019
@AdamSLevy AdamSLevy added this to the v1 milestone Sep 17, 2019
@AdamSLevy AdamSLevy removed this from the v1 milestone Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fatd
Projects
None yet
Development

No branches or pull requests

1 participant