Update the registration list to include NoFrameskip-v4

Author: pseudo-rnd-thoughts

docs/environments.md

@@ -205,11 +205,12 @@ Actions passed into the environment are then thresholded to discrete using the `
 
 ## Version History and Naming Schemes
 
-In v0.11, the number of registered Atari environments does significantly reduced from 960 to 105 to only register `ALE/{rom_name}-v5` following the best practices outlined in [[2]](#2).
+In v0.11, the number of registered Atari environments was significantly reduced from 960 to 210 to only register `{rom_name}NoFrameskip-v4` the most popular environment and `ALE/{rom_name}-v5` following the best practices outlined in [[2]](#2).
 
-| Name             | `obs_type=` | `frameskip=` | `repeat_action_probability=` | `full_ation_space=` |
-|------------------|-------------|--------------|------------------------------|---------------------|
-| ALE/Adventure-v5 | `"rgb"`     | `4`          | `0.25`                       | `False`             |
+| Name                    | `obs_type=` | `frameskip=` | `repeat_action_probability=` | `full_ation_space=` |
+|-------------------------|-------------|--------------|------------------------------|---------------------|
+| AdventureNoFrameskip-v4 | `"rgb"`     | `1`          | `0.00`                       | `False`             |
+| ALE/Adventure-v5        | `"rgb"`     | `4`          | `0.25`                       | `False`             |
 
 Importantly, `repeat_action_probability=0.25` can negatively impact the performance of agents so when comparing training graphs, be aware of the parameters used for fair comparisons.
 
@@ -229,6 +230,7 @@ To create previously implemented environment use the following parameters, `gymn
 | Adventure-ram-v4              | `"ram"`     | `(2, 5,)`    | `0.0`                        | `False`              |
 | Adventure-ramDeterministic-v4 | `"ram"`     | `4`          | `0.0`                        | `False`              |
 | Adventure-ramNoframeskip-v4   | `"ram"`     | `1`          | `0.0`                        | `False`              |
+| ALE/Adventure-v5              | `"rgb"`     | `4`          | `0.25`                       | `False`              |
 | ALE/Adventure-ram-v5          | `"ram"`     | `4`          | `0.25`                       | `False`              |
 
 ## Flavors

src/ale/python/registration.py

@@ -2,6 +2,8 @@
 
 from __future__ import annotations
 
+from collections import defaultdict
+
 import ale_py.roms as roms
 import gymnasium
 
@@ -14,19 +16,39 @@ def rom_id_to_name(rom: str) -> str:
 def register_envs():
     """Register all the Atari Environments."""
     all_rom_ids = roms.get_all_rom_ids()
+    # These environments all don't have a single agent implementation
+    all_rom_ids.remove("warlords")
+    all_rom_ids.remove("maze_craze")
+    all_rom_ids.remove("joust")
+    all_rom_ids.remove("combat")
 
     for rom_id in all_rom_ids:
+        gymnasium.register(
+            id=f"{rom_id_to_name(rom_id)}NoFrameskip-v4",
+            entry_point="ale_py.env:AtariEnv",
+            kwargs={
+                "game": rom_id,
+                "obs_type": "rgb",
+                "frameskip": 1,  # frameskip of 1
+                # max_episode_steps is 108k frames which is 30 mins of gameplay.
+                # This corresponds to 108k / 4 = 27,000 steps
+                "max_num_frames_per_episode": 108_000,
+                "repeat_action_probability": 0,  # no repeat action probability
+                "full_action_space": False,
+            },
+        )
+
         gymnasium.register(
             id=f"ALE/{rom_id_to_name(rom_id)}-v5",
             entry_point="ale_py.env:AtariEnv",
             kwargs={
                 "game": rom_id,
                 "obs_type": "rgb",
-                "frameskip": 1,
+                "frameskip": 4,  # frameskip of 4
                 # max_episode_steps is 108k frames which is 30 mins of gameplay.
                 # This corresponds to 108k / 4 = 27,000 steps
                 "max_num_frames_per_episode": 108_000,
-                "repeat_action_probability": 0,
+                "repeat_action_probability": 0.25,  # include repeat action probability
                 "full_action_space": False,
             },
         )

tests/python/test_atari_env.py

@@ -22,8 +22,10 @@ def test_roms_register():
     ]
 
     registered_v5_roms = list(filter(lambda env_id: "v5" in env_id, registered_roms))
-    assert len(registered_v5_roms) == 108
-    assert len(registered_roms) == len(registered_v5_roms)
+    assert len(registered_v5_roms) == 104
+    registered_noframeskip_v4_roms = list(filter(lambda env_id: "NoFrameskip-v4" in env_id, registered_roms))
+    assert len(registered_noframeskip_v4_roms) == 104
+    assert len(registered_roms) == len(registered_v5_roms) + len(registered_noframeskip_v4_roms)
 
 
 @pytest.mark.parametrize(