fix: convert native PHP floats to single precision (protocolbuffers#8187)

bshaffer · web-flow · commit 468bc193ec15 · 2021-01-11T11:53:35.000-08:00
* fix: convert native PHP floats to single precision

* fix unpack
diff --git a/php/src/Google/Protobuf/Internal/GPBUtil.php b/php/src/Google/Protobuf/Internal/GPBUtil.php
@@ -168,7 +168,7 @@ public static function checkUint64(&$var)
     public static function checkFloat(&$var)
     {
         if (is_float($var) || is_numeric($var)) {
-            $var = floatval($var);
+            $var = unpack("f", pack("f", $var))[1];
         } else {
             throw new \Exception("Expect float.");
         }

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ public static function checkUint64(&$var)`
`168`	`168`	`public static function checkFloat(&$var)`
`169`	`169`	`{`
`170`	`170`	`if (is_float($var) \|\| is_numeric($var)) {`
`171`		`- $var = floatval($var);`
	`171`	`+ $var = unpack("f", pack("f", $var))[1];`
`172`	`172`	`} else {`
`173`	`173`	`throw new \Exception("Expect float.");`
`174`	`174`	`}`