Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure Vcycle and Diffusion Solver #158

Open
LinhWuerzburger opened this issue Sep 1, 2021 · 1 comment
Open

Restructure Vcycle and Diffusion Solver #158

LinhWuerzburger opened this issue Sep 1, 2021 · 1 comment
Labels
effort: middle expected time effort: up to 1 week investigate investigate if the code is correct type: refactoring clean up and refactoring

Comments

@LinhWuerzburger
Copy link
Contributor

In VCycleMG.cpp is duplicate code, which is from the respective diffusion solver. To prevent duplicate code, investigate whether it is possible to restructure the Diffusion Solver Jacobi as well ColoredGaussSeidel as such that the error/residuum calculation doesn't need to be done in the VCycleMG class.
@LinhWuerzburger LinhWuerzburger added type: refactoring clean up and refactoring effort: middle expected time effort: up to 1 week investigate investigate if the code is correct labels Sep 1, 2021
@LinhWuerzburger
Copy link
Contributor Author

regarding the diffusion solver Jacobi: as you can see in the picture, the function for multigrid and non multigrid are almost the same. needs only a bit a restructuring.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: middle expected time effort: up to 1 week investigate investigate if the code is correct type: refactoring clean up and refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LinhWuerzburger