More cleanups

Author: Roemer

src/FlaUInspect/App.xaml.cs

@@ -1,6 +1,5 @@
 using System.Reflection;
 using System.Windows;
-using FlaUI.Core;
 using FlaUInspect.Core.Logger;
 using FlaUInspect.ViewModels;
 using FlaUInspect.Views;

src/FlaUInspect/Core/Extensions/AutomationPropertyExtensions.cs

@@ -5,9 +5,7 @@ namespace FlaUInspect.Core.Extensions;
 public static class AutomationPropertyExtensions {
     public static string? ToDisplayText<T>(this IAutomationProperty<T?> automationProperty) {
         try {
-#pragma warning disable CA1416
             bool success = automationProperty.TryGetValue(out T? value);
-#pragma warning restore CA1416
             return success ? value == null ? string.Empty : value.ToString() : "Not Supported";
         }
         catch (Exception ex) {

src/FlaUInspect/Core/FocusTrackingMode.cs

@@ -1,5 +1,4 @@
-using System.Diagnostics;
-using FlaUI.Core;
+using FlaUI.Core;
 using FlaUI.Core.AutomationElements;
 using FlaUI.Core.EventHandlers;
 using Application = System.Windows.Application;

src/FlaUInspect/Core/HoverMode.cs

@@ -1,6 +1,4 @@
-using System.Diagnostics;
-using System.Diagnostics.CodeAnalysis;
-using System.Windows.Input;
+using System.Windows.Input;
 using System.Windows.Threading;
 using FlaUI.Core;
 using FlaUI.Core.AutomationElements;
@@ -36,7 +34,6 @@ public void Stop() {
         _dispatcherTimer.Stop();
     }
 
-    [SuppressMessage("Interoperability", "CA1416:Validate platform compatibility")]
     private void DispatcherTimerTick(object? sender, EventArgs e) {
         if (Keyboard.Modifiers.HasFlag(ModifierKeys.Control)) {
             Point screenPos = Mouse.Position;
@@ -46,7 +43,7 @@ private void DispatcherTimerTick(object? sender, EventArgs e) {
 
                 // Skip items in the current process
                 // Like Inspect itself or the overlay window
-                if (hoveredElement?.Properties.ProcessId == Process.GetCurrentProcess().Id) {
+                if (hoveredElement?.Properties.ProcessId == Environment.ProcessId) {
                     return;
                 }
 

src/FlaUInspect/Core/ObservableObject.cs

@@ -1,14 +1,12 @@
 using System.ComponentModel;
-using System.Diagnostics.CodeAnalysis;
 using System.Linq.Expressions;
 using System.Runtime.CompilerServices;
 
 namespace FlaUInspect.Core;
 
-[SuppressMessage("ReSharper", "ExplicitCallerInfoArgument")]
 public abstract class ObservableObject : INotifyPropertyChanged {
 
-    private readonly Dictionary<string, object?> _backingFieldValues = new ();
+    private readonly Dictionary<string, object?> _backingFieldValues = [];
     public event PropertyChangedEventHandler? PropertyChanged;
 
     /// <summary>

src/FlaUInspect/Core/PatternItemsFactory.cs

@@ -24,7 +24,6 @@
 
 namespace FlaUInspect.Core;
 
-[SuppressMessage("Interoperability", "CA1416:Validate platform compatibility")]
 public class PatternItemsFactory(AutomationBase? automationBase) {
     public const string Identification = "Identification";
     public const string Details = "Details";

src/FlaUInspect/ViewModels/MainViewModel.cs

@@ -20,7 +20,6 @@
 
 namespace FlaUInspect.ViewModels;
 
-[SuppressMessage("Interoperability", "CA1416:Validate platform compatibility")]
 public class MainViewModel : ObservableObject {
 
     private readonly object _itemsLock = new();
@@ -162,7 +161,7 @@ private void ReadPatternsForSelectedItem(AutomationElement? selectedItemAutomati
         }
 
         try {
-            HashSet<PatternId> supportedPatterns = selectedItemAutomationElement.GetSupportedPatterns().ToHashSet();
+            HashSet<PatternId> supportedPatterns = [.. selectedItemAutomationElement.GetSupportedPatterns()];
             IDictionary<string, PatternItem[]> patternItemsForElement = _patternItemsFactory.CreatePatternItemsForElement(selectedItemAutomationElement, supportedPatterns);
 
             foreach (ElementPatternItem elementPattern in ElementPatterns) {

src/FlaUInspect/Views/ErrorListWindow.xaml.cs

@@ -6,7 +6,7 @@ public partial class ErrorListWindow {
     public ErrorListWindow(InternalLogger logger) {
         InitializeComponent();
 
-        List<InternalLoggerMessage> internalLoggerMessages = logger.Messages.ToList();
+        List<InternalLoggerMessage> internalLoggerMessages = [.. logger.Messages];
         ErrorItemsControl.ItemsSource = internalLoggerMessages;
     }
 }