Skip to content

[Iluvatar] transpose to match actual tensor layout #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025

Conversation

awayzjj
Copy link
Collaborator

@awayzjj awayzjj commented Jul 14, 2025

PR Category

Type of Change

Description

Issue

Progress

  • Change is properly reviewed (1 reviewer required, 2 recommended).
  • Change is responded to an issue.
  • Change is fully covered by a UT.

Performance

@awayzjj awayzjj marked this pull request as ready for review July 15, 2025 01:09
Copy link
Contributor

@tongxin tongxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Junjian. It's not clear to me what benefits it brings. The kernel is idempotent subject to input transpose.

@awayzjj
Copy link
Collaborator Author

awayzjj commented Jul 16, 2025

@StrongSpoon Please help me review the code about flash mla. Thanks!

@awayzjj
Copy link
Collaborator Author

awayzjj commented Jul 17, 2025

@tongxin I’ve added the relevant comments. please review it again, thank you!

Copy link
Collaborator

@StrongSpoon StrongSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@StrongSpoon StrongSpoon merged commit 67c95fe into FlagOpen:master Jul 17, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants