Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better support for darkmode #110

Closed
mlopezFC opened this issue Dec 10, 2024 · 0 comments · Fixed by #111
Closed

Add better support for darkmode #110

mlopezFC opened this issue Dec 10, 2024 · 0 comments · Fixed by #111
Assignees
@javier-godoy
Labels
enhancement New feature or request

Comments

@mlopezFC
Copy link
Member

It would be nice to inform addons demos that darkmode was activated so they can react accordingly. As an example some addons have iframes so they would need to know if the darkmode changed to apply the change to the inner iframe
@mlopezFC mlopezFC added the enhancement New feature or request label Dec 10, 2024
@github-project-automation github-project-automation bot moved this to Inbox (needs triage) in Flowing Code Addons Dec 10, 2024
@javier-godoy javier-godoy self-assigned this Dec 23, 2024
@javier-godoy javier-godoy moved this from Inbox (needs triage) to To Do in Flowing Code Addons Dec 23, 2024
javier-godoy added a commit that referenced this issue Dec 23, 2024
@javier-godoy
feat: add ThemeChangeObserver
ffd09d3 
Close #110
@javier-godoy javier-godoy mentioned this issue Dec 23, 2024
Merged
@javier-godoy javier-godoy moved this from To Do to In Progress in Flowing Code Addons Dec 26, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Flowing Code Addons Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javier-godoy javier-godoy

Labels
enhancement New feature or request
Projects
Flowing Code Addons
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add ThemeChangeObserver FlowingCode/CommonsDemo
2 participants
@javier-godoy @mlopezFC