Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets with code inside are ignored #1847

Open
dmitryd opened this issue Mar 2, 2023 · 2 comments
Open

Assets with code inside are ignored #1847

dmitryd opened this issue Mar 2, 2023 · 2 comments

Comments

@dmitryd
Copy link
Contributor

dmitryd commented Mar 2, 2023

Example:

        <v:asset.script name="iframe-resizer-init" movable="1">
            iFrameResize({}, ".iframe-responsive-height");
        </v:asset.script>

This does not produce ANY output at all. I traced it down to FluidTYPO3\Vhs\Service\AssetService::manipulateAssetsByTypoScriptSettings():

asset

This shows that the content of the <v:asset.script> and <v:asset.style> will be ignored.

@MohsinQK
Copy link
Contributor

I also have the same Problem.
TYPO3 V11
VHS 6.1.3
PHP v8.1

@NamelessCoder
Copy link
Member

Thanks @dmitryd - could you check if 2390e80 (already in dev-development) solves the issue? I changed it so rather than checking for Asset it checks for AssetInterface which will now be fulfilled by ScriptViewHelper and StyleViewHelper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants