Skip to content

Commit 1ce79b6

Browse files
authored
Merge pull request #705 from Flutterando/fix/release5
fix: prepare to release
2 parents d10cdf7 + 57413a5 commit 1ce79b6

File tree

24 files changed

+232
-84
lines changed

24 files changed

+232
-84
lines changed

flutter_modular/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
## [5.0.0] - 2022-04-21
2+
- Support Flutter 3.0.0
23
- [BREAK CHANGE]: Removed `MaterialApp.modular()` and `Cupertino().modular()`.
34
Use instead:
45
```dart

flutter_modular/example/linux/flutter/generated_plugins.cmake

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
list(APPEND FLUTTER_PLUGIN_LIST
66
)
77

8+
list(APPEND FLUTTER_FFI_PLUGIN_LIST
9+
)
10+
811
set(PLUGIN_BUNDLED_LIBRARIES)
912

1013
foreach(plugin ${FLUTTER_PLUGIN_LIST})
@@ -13,3 +16,8 @@ foreach(plugin ${FLUTTER_PLUGIN_LIST})
1316
list(APPEND PLUGIN_BUNDLED_LIBRARIES $<TARGET_FILE:${plugin}_plugin>)
1417
list(APPEND PLUGIN_BUNDLED_LIBRARIES ${${plugin}_bundled_libraries})
1518
endforeach(plugin)
19+
20+
foreach(ffi_plugin ${FLUTTER_FFI_PLUGIN_LIST})
21+
add_subdirectory(flutter/ephemeral/.plugin_symlinks/${ffi_plugin}/linux plugins/${ffi_plugin})
22+
list(APPEND PLUGIN_BUNDLED_LIBRARIES ${${ffi_plugin}_bundled_libraries})
23+
endforeach(ffi_plugin)

flutter_modular/lib/src/presenter/navigation/modular_router_delegate.dart

Lines changed: 79 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,10 @@ class ModularRouterDelegate extends RouterDelegate<ModularBook>
2424
final ReportPop reportPop;
2525
List<NavigatorObserver> observers = [];
2626

27-
ModularRouterDelegate({required this.parser, required this.navigatorKey, required this.reportPop});
27+
ModularRouterDelegate(
28+
{required this.parser,
29+
required this.navigatorKey,
30+
required this.reportPop});
2831

2932
@override
3033
ModularBook? currentConfiguration;
@@ -65,8 +68,11 @@ class ModularRouterDelegate extends RouterDelegate<ModularBook>
6568
Future<void> setNewRoutePath(ModularBook configuration) async {
6669
final disposableRoutes = <ParallelRoute>[];
6770

68-
for (var route in currentConfiguration?.routes ?? <ParallelRoute<dynamic>>[]) {
69-
if (configuration.routes.indexWhere((element) => element.uri.path == route.uri.path) == -1) {
71+
for (var route
72+
in currentConfiguration?.routes ?? <ParallelRoute<dynamic>>[]) {
73+
if (configuration.routes
74+
.indexWhere((element) => element.uri.path == route.uri.path) ==
75+
-1) {
7076
disposableRoutes.add(route);
7177
}
7278
}
@@ -112,28 +118,41 @@ class ModularRouterDelegate extends RouterDelegate<ModularBook>
112118
final parallel = page.route;
113119
parallel.popCallback?.call(result);
114120
currentConfiguration?.routes.remove(parallel);
115-
if (currentConfiguration?.routes.indexWhere((element) => element.uri.toString() == parallel.uri.toString()) == -1) {
121+
if (currentConfiguration?.routes.indexWhere(
122+
(element) => element.uri.toString() == parallel.uri.toString()) ==
123+
-1) {
116124
reportPop.call(parallel);
117125
}
118-
final arguments = parser.getArguments().getOrElse((l) => ModularArguments.empty());
126+
final arguments =
127+
parser.getArguments().getOrElse((l) => ModularArguments.empty());
119128
parser.setArguments(arguments.copyWith(uri: currentConfiguration!.uri));
120129
notifyListeners();
121130

122131
return true;
123132
}
124133

125134
@override
126-
Future<T?> pushNamed<T extends Object?>(String routeName, {Object? arguments, bool forRoot = false}) async {
135+
Future<T?> pushNamed<T extends Object?>(String routeName,
136+
{Object? arguments, bool forRoot = false}) async {
127137
final popComplete = Completer();
128-
var book = await parser.selectBook(routeName, arguments: arguments, popCallback: popComplete.complete);
138+
var book = await parser.selectBook(routeName,
139+
arguments: arguments, popCallback: popComplete.complete);
129140
if (forRoot) {
130-
book = currentConfiguration!.copyWith(routes: [...currentConfiguration!.routes, book.routes.last.copyWith(schema: '')]);
141+
book = currentConfiguration!.copyWith(routes: [
142+
...currentConfiguration!.routes,
143+
book.routes.last.copyWith(schema: '')
144+
]);
131145
await setNewRoutePath(book);
132146
} else {
133147
final list = [...currentConfiguration!.routes];
134148

135149
for (var route in book.routes.reversed) {
136-
if (list.firstWhere((element) => element.uri.toString() == route.uri.toString(), orElse: () => ParallelRoute.empty()).name == '') {
150+
if (list
151+
.firstWhere(
152+
(element) => element.uri.toString() == route.uri.toString(),
153+
orElse: () => ParallelRoute.empty())
154+
.name ==
155+
'') {
137156
list.add(route);
138157
}
139158
}
@@ -149,21 +168,32 @@ class ModularRouterDelegate extends RouterDelegate<ModularBook>
149168
}
150169

151170
@override
152-
Future<T?> pushReplacementNamed<T extends Object?, TO extends Object?>(String routeName, {TO? result, Object? arguments, bool forRoot = false}) async {
171+
Future<T?> pushReplacementNamed<T extends Object?, TO extends Object?>(
172+
String routeName,
173+
{TO? result,
174+
Object? arguments,
175+
bool forRoot = false}) async {
153176
final popComplete = Completer();
154-
var book = await parser.selectBook(routeName, arguments: arguments, popCallback: popComplete.complete);
177+
var book = await parser.selectBook(routeName,
178+
arguments: arguments, popCallback: popComplete.complete);
155179
final currentRoutes = [...currentConfiguration!.routes];
156180
if (forRoot) {
157181
//;currentRoutes.removeWhere((element) => element.schema != '');
158-
final indexLast = currentRoutes.lastIndexWhere((element) => element.schema == '');
182+
final indexLast =
183+
currentRoutes.lastIndexWhere((element) => element.schema == '');
159184
currentRoutes[indexLast] = book.routes.first.copyWith(schema: '');
160185
book = currentConfiguration!.copyWith(routes: [...currentRoutes]);
161186
await setNewRoutePath(book);
162187
} else {
163188
final list = currentRoutes..removeLast();
164189

165190
for (var route in book.routes.reversed) {
166-
if (list.firstWhere((element) => element.uri.toString() == route.uri.toString(), orElse: () => ParallelRoute.empty()).name == '') {
191+
if (list
192+
.firstWhere(
193+
(element) => element.uri.toString() == route.uri.toString(),
194+
orElse: () => ParallelRoute.empty())
195+
.name ==
196+
'') {
167197
list.add(route);
168198
}
169199
}
@@ -174,7 +204,11 @@ class ModularRouterDelegate extends RouterDelegate<ModularBook>
174204
}
175205

176206
@override
177-
Future<T?> popAndPushNamed<T extends Object?, TO extends Object?>(String routeName, {TO? result, Object? arguments, bool forRoot = false}) {
207+
Future<T?> popAndPushNamed<T extends Object?, TO extends Object?>(
208+
String routeName,
209+
{TO? result,
210+
Object? arguments,
211+
bool forRoot = false}) {
178212
pop(result);
179213
return pushNamed(routeName, arguments: arguments);
180214
}
@@ -183,15 +217,20 @@ class ModularRouterDelegate extends RouterDelegate<ModularBook>
183217
bool canPop() => navigatorKey.currentState?.canPop() ?? false;
184218

185219
@override
186-
Future<bool> maybePop<T extends Object?>([T? result]) => navigatorKey.currentState?.maybePop(result) ?? Future.value(false);
220+
Future<bool> maybePop<T extends Object?>([T? result]) =>
221+
navigatorKey.currentState?.maybePop(result) ?? Future.value(false);
187222

188223
@override
189-
void pop<T extends Object?>([T? result]) => navigatorKey.currentState?.pop(result);
224+
void pop<T extends Object?>([T? result]) =>
225+
navigatorKey.currentState?.pop(result);
190226

191227
@override
192228
void popUntil(bool Function(Route) predicate) {
193229
var isFoundedPages = currentConfiguration?.routes.where((route) {
194-
return predicate(CustomModalRoute(ModularPage(route: route, args: ModularArguments.empty(), flags: ModularFlags())));
230+
return predicate(CustomModalRoute(ModularPage(
231+
route: route,
232+
args: ModularArguments.empty(),
233+
flags: ModularFlags())));
195234
});
196235

197236
isFoundedPages ??= [];
@@ -203,21 +242,36 @@ class ModularRouterDelegate extends RouterDelegate<ModularBook>
203242
}
204243

205244
@override
206-
Future<T?> pushNamedAndRemoveUntil<T extends Object?>(String routeName, bool Function(Route) predicate, {Object? arguments, bool forRoot = false}) async {
245+
Future<T?> pushNamedAndRemoveUntil<T extends Object?>(
246+
String routeName, bool Function(Route) predicate,
247+
{Object? arguments, bool forRoot = false}) async {
207248
final popComplete = Completer();
208-
var book = await parser.selectBook(routeName, arguments: arguments, popCallback: popComplete.complete);
249+
var book = await parser.selectBook(routeName,
250+
arguments: arguments, popCallback: popComplete.complete);
209251
if (forRoot) {
210252
final list = currentConfiguration!.routes.where((route) {
211-
return predicate(CustomModalRoute(ModularPage(route: route, args: ModularArguments.empty(), flags: ModularFlags())));
253+
return predicate(CustomModalRoute(ModularPage(
254+
route: route,
255+
args: ModularArguments.empty(),
256+
flags: ModularFlags())));
212257
}).toList();
213-
book = currentConfiguration!.copyWith(routes: [...list, book.routes.last.copyWith(schema: '')]);
258+
book = currentConfiguration!
259+
.copyWith(routes: [...list, book.routes.last.copyWith(schema: '')]);
214260
await setNewRoutePath(book);
215261
} else {
216262
final list = currentConfiguration!.routes.where((route) {
217-
return predicate(CustomModalRoute(ModularPage(route: route, args: ModularArguments.empty(), flags: ModularFlags())));
263+
return predicate(CustomModalRoute(ModularPage(
264+
route: route,
265+
args: ModularArguments.empty(),
266+
flags: ModularFlags())));
218267
}).toList();
219268
for (var route in book.routes.reversed) {
220-
if (list.firstWhere((element) => element.uri.toString() == route.uri.toString(), orElse: () => ParallelRoute.empty()).name == '') {
269+
if (list
270+
.firstWhere(
271+
(element) => element.uri.toString() == route.uri.toString(),
272+
orElse: () => ParallelRoute.empty())
273+
.name ==
274+
'') {
221275
list.add(route);
222276
}
223277
}
@@ -250,7 +304,8 @@ class CustomModalRoute extends ModalRoute {
250304
String? get barrierLabel => throw UnimplementedError();
251305

252306
@override
253-
Widget buildPage(BuildContext context, Animation<double> animation, Animation<double> secondaryAnimation) {
307+
Widget buildPage(BuildContext context, Animation<double> animation,
308+
Animation<double> secondaryAnimation) {
254309
throw UnimplementedError();
255310
}
256311

flutter_modular/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
name: flutter_modular
22
description: Smart project structure with dependency injection and route management
3-
version: 5.0.0-dev.15
3+
version: 5.0.0
44
homepage: https://github.com/Flutterando/modular
55

66
environment:
77
sdk: ">=2.12.0 <3.0.0"
88

99
dependencies:
1010
flutter_modular_annotations: ^0.0.2
11-
modular_core: 2.0.0-dev.10
11+
modular_core: ">=2.0.0 <3.0.0"
1212
meta: ">=1.3.0 <2.0.0"
1313
flutter:
1414
sdk: flutter

0 commit comments

Comments
 (0)