Skip to content

Commit 269ed03

Browse files
authored
Merge pull request #662 from Flutterando/fix_test
Fix test
2 parents 02e146f + d029e6e commit 269ed03

File tree

10 files changed

+30
-16
lines changed

10 files changed

+30
-16
lines changed

flutter_modular/example/lib/app/app_widget.dart

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,14 @@ class AppWidget extends StatelessWidget {
99

1010
@override
1111
Widget build(BuildContext context) {
12-
return MaterialApp(
13-
navigatorKey: alice.getNavigatorKey(),
12+
Modular.routerDelegate.setNavigatorKey(alice.getNavigatorKey());
13+
return MaterialApp.router(
1414
title: 'Flutter Slidy',
1515
theme: ThemeData(
1616
primarySwatch: Colors.blue,
1717
),
18-
).modular();
18+
routerDelegate: Modular.routerDelegate,
19+
routeInformationParser: Modular.routeInformationParser,
20+
);
1921
}
2022
}

flutter_modular/lib/flutter_modular.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import 'src/domain/usecases/get_arguments.dart';
99
import 'src/presenter/models/modular_navigator.dart';
1010
import 'src/presenter/modular_base.dart';
1111
import 'src/presenter/navigation/modular_page.dart';
12-
import 'src/presenter/navigation/modular_route_information_parser.dart';
1312
import 'src/presenter/navigation/modular_router_delegate.dart';
1413
import 'src/presenter/navigation/router_outlet_delegate.dart';
1514

@@ -65,7 +64,7 @@ extension ModularExtensionMaterial on MaterialApp {
6564
///...
6665
///);
6766
///```
68-
@deprecated
67+
@Deprecated('Use **MaterialApp.router** instead')
6968
MaterialApp modular() {
7069
injector
7170
.get<IModularNavigator>()
@@ -120,7 +119,7 @@ extension ModularExtensionCupertino on CupertinoApp {
120119
///...
121120
///);
122121
///```
123-
@deprecated
122+
@Deprecated('Use CupertinoApp.router instead')
124123
CupertinoApp modular() {
125124
injector
126125
.get<IModularNavigator>()

flutter_modular/lib/src/presenter/navigation/modular_route_information_parser.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import 'dart:async';
22

33
import 'package:flutter/material.dart';
4-
54
import 'package:modular_core/modular_core.dart';
65

76
import '../../../flutter_modular.dart';

flutter_modular/test/src/presenter/navigation/modular_router_delegate_test.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,10 @@ void main() {
5151
when(() => key.currentState).thenReturn(navigatorState);
5252
parser = ModularRouteInformationParserMock();
5353
delegate = ModularRouterDelegate(
54-
parser: parser, navigatorKey: key, reportPop: reportPopMock);
54+
parser: parser,
55+
navigatorKey: key,
56+
reportPop: reportPopMock,
57+
);
5558
});
5659

5760
test('setObserver', () {

modular_codegen/lib/src/custom_annotation_generator.dart

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,19 @@ import 'package:analyzer/dart/element/element.dart';
33
import 'package:build/build.dart';
44
import 'package:source_gen/source_gen.dart';
55

6-
abstract class CustomGeneratorForAnnotatedField<AnnotationType> extends Generator {
6+
abstract class CustomGeneratorForAnnotatedField<AnnotationType>
7+
extends Generator {
78
/// Returns the annotation of type [AnnotationType] of the given [element],
89
/// or [null] if it doesn't have any.
910
DartObject? getAnnotation(Element element) {
10-
final annotations = TypeChecker.fromRuntime(AnnotationType).annotationsOf(element);
11+
final annotations =
12+
TypeChecker.fromRuntime(AnnotationType).annotationsOf(element);
1113
if (annotations.isEmpty) {
1214
return null;
1315
}
1416
if (annotations.length > 1) {
15-
throw Exception("You tried to add multiple @$AnnotationType() annotations to the "
17+
throw Exception(
18+
"You tried to add multiple @$AnnotationType() annotations to the "
1619
"same element (${element.name}), but that's not possible.");
1720
}
1821
return annotations.single;
@@ -39,5 +42,6 @@ abstract class CustomGeneratorForAnnotatedField<AnnotationType> extends Generato
3942
return values.join('/n/n');
4043
}
4144

42-
String generateForAnnotatedField(FieldElement field, ConstantReader annotation);
45+
String generateForAnnotatedField(
46+
FieldElement field, ConstantReader annotation);
4347
}

modular_codegen/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: modular_codegen
22
description: Code Generate for flutter_modular. Inject Automation. Annotation @Inject, @Param and @Data.
3-
version: 3.0.3
3+
version: 3.0.4
44
homepage: https://github.com/Flutterando/modular
55

66
environment:

modular_core/lib/src/route/tracker.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,8 @@ class TrackerImpl implements Tracker {
113113
params[name] = result.namedGroup(name)!;
114114
}
115115
return params;
116+
} else {
117+
return null;
116118
}
117119
}
118120

modular_interfaces/lib/src/di/bind.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ abstract class BindContract<T extends Object> {
2828
this.export = false,
2929
this.isScoped = false,
3030
this.alwaysSerialized = false,
31-
}) : assert((isSingleton || isLazy), r"'singleton' can't be false if 'lazy' is also false");
31+
}) : assert((isSingleton || isLazy),
32+
r"'singleton' can't be false if 'lazy' is also false");
3233
}
3334

3435
/// For empty instance binds.

modular_test/lib/modular_test.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ library modular_test;
22

33
import 'package:modular_core/modular_core.dart';
44

5-
void initModule(BindContext module, {List<BindContract> replaceBinds = const []}) {
5+
void initModule(BindContext module,
6+
{List<BindContract> replaceBinds = const []}) {
67
// ignore: invalid_use_of_visible_for_testing_member
78
final bindModules = module.getProcessBinds();
89

@@ -18,7 +19,8 @@ void initModule(BindContext module, {List<BindContract> replaceBinds = const []}
1819
ModularTracker.injector.addBindContext(module);
1920
}
2021

21-
void initModules(List<BindContext> modules, {List<BindContract> replaceBinds = const []}) {
22+
void initModules(List<BindContext> modules,
23+
{List<BindContract> replaceBinds = const []}) {
2224
for (var module in modules) {
2325
initModule(module, replaceBinds: replaceBinds);
2426
}

shelf_modular/lib/src/presenter/utils/handlers.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,5 +73,7 @@ FutureOr<Response>? applyHandler(Function fn,
7373
return fn(injector, arguments, request);
7474
} else if (fn is HandlerThreeParams5) {
7575
return fn(injector, request, arguments);
76+
} else {
77+
return null;
7678
}
7779
}

0 commit comments

Comments
 (0)