Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require walks to always take a KeyPath object as first argument #77

Open
CarloLucibello opened this issue Mar 11, 2024 · 1 comment
Open
Labels

Comments

@CarloLucibello
Copy link
Member

This issue keeps track of the breaking change proposed in #74 (review) in order to avoid duplicating walks, e.g. defining SomeWalk and also SomeWalkWithPath.

@ToucheSir
Copy link
Member

I realize this is the second time I've brought up keyword args today, but could we introduce this change without breaking anything by making the keypath a kwarg of walk constructors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants