Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spectacle-mdx-loader: MDX component map lacks a lot of things that Markdown supports #1232

Open
ryan-roemer opened this issue Sep 21, 2022 · 0 comments
Labels
🐛 Bug Issues or PRs that report or fix a bug

Comments

@ryan-roemer
Copy link
Member

We have a discrepancy in code blocks in MD vs. MDX and likely other Spectacle core component support.

Example

For our MD example with pnpm start:md for the code page we have:

Screen Shot 2022-09-21 at 1 50 03 PM

For our MDX example with pnpm start:mdx for the code page with exact same sample we have:

Screen Shot 2022-09-21 at 1 50 08 PM

Cause

Our Markdown component and related components do a lot more things than our mdxComponentMap does that we pass into MDX.

Work

See if we can expand mdxComponentMap to something more general that ideally doesn't rejigger core Spectacle too much.

@ryan-roemer ryan-roemer added the 🐛 Bug Issues or PRs that report or fix a bug label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Issues or PRs that report or fix a bug
Projects
None yet
Development

No branches or pull requests

1 participant