Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch coverage data in FineCodeCoverage view's Coverage tab #29

Closed
guitax opened this issue Nov 19, 2020 · 13 comments
Closed

Add branch coverage data in FineCodeCoverage view's Coverage tab #29

guitax opened this issue Nov 19, 2020 · 13 comments
Assignees
Labels
custom report custom report feature

Comments

@guitax
Copy link

guitax commented Nov 19, 2020

Description

Add branch coverage data to FineCodeCoverage view in "Coverage" tab.

Current behavior

Only Line Coverage is shown in the "Coverage" tab.

Expected behavior

Show also data for Branch Coverage like:
image

@FortuneN
Copy link
Owner

FortuneN commented Nov 19, 2020

The concern i have is to 'eat up' too much (horizontal) space so much so that we can't render class names properly or worse, horizontal scroll.

Maybe i could render only 'the Branch coverage' chart and percentage but not the other columns ('Covered', 'Total')

What do you think?

99706246-137a1f00-2a9b-11eb-82f3-ae81f835ac2f

@guitax
Copy link
Author

guitax commented Nov 20, 2020

Yeah, I understand your concern and I think your suggestion is ok.
Thank you, and good work by the way!

@FortuneN FortuneN added the enhancement New feature or request label Nov 21, 2020
@tonyhallett
Copy link
Collaborator

@FortuneN
It is necessary to show the branch coverage.
Consider the following report generated outside of Fine Code Coverage

reporter_report

If you were to look at the output window for Fine Code Coverage you would think that all was well with these tests.
fccReport

The concern i have is to 'eat up' too much (horizontal) space so much so that we can't render class names properly or worse, horizontal scroll.

Class names go first so that is not a consideration. I don't think any user of the addin is going to consider horizontal scroll a problem if there is data there to be seen.

I personally think that the percentages are sufficient. When the report view is provided by Fine Code Coverage itself ( #49 ) the other values could be provided as tool tips.

I would also include the additional functionality present in the webpage from the report generator - the grouping / filtering and facility to view the results for the individual methods ( that did not get 100% line coverage / branch coverage )

@t-johnson
Copy link
Contributor

+1 for adding branch coverage. if Horizontal space is an issue, then drop the colored bar that represents the percentages. its duplicate information.
Perhaps could have it as an option to control what columns style is shown?

@FortuneN
Copy link
Owner

FortuneN commented Jan 13, 2021

@t-johnson I think we need to keep the bar. I mostly just look at the bars and see how much red there is and start working on those areas until it's mostly green.

Anyways, the reason why this remains unresolved is that the easy way has a LOT of IO (+ time) cost. I need a bit of of time to handle it properly and i'm a bit short on time at the moment.

If you are interested in working on this we can have a discussion about the background so you can get started

@tonyhallett
Copy link
Collaborator

@FortuneN @t-johnson I am working on this. Please do not do any work on this until I show my results as I have invested some time on it.

I will facilitate showing all all line and branch columns with options to exclude columns that you are not interested in.

@t-johnson
Copy link
Contributor

@FortuneN
Sure, I think the value of the visual bar might be good in some cases. What might be better is to be able to view the summary down to the method/property level... but thats probably another problem all together.
@tonyhallett let me know if you need help with testing.

@FortuneN
Copy link
Owner

FortuneN commented Jan 13, 2021

@t-johnson
The current screen comes straight out of ReportGenerator (https://github.com/danielpalme/ReportGenerator) and for zero effort on my part; it has been a good start.

As mentioned by him above, @tonyhallett is working on the NEW AND IMPROVED :) custom screen.
Perhaps discuss the ideas that you have and maybe we'll incorporate them into the new design.

@tonyhallett tonyhallett added custom report custom report feature and removed enhancement New feature or request labels Feb 7, 2021
@tonyhallett tonyhallett self-assigned this Feb 26, 2021
@RichardPetheram
Copy link

How's progress on this? Branch coverage is a significant issue for me on current projects; if it will be available soon I would be amazingly happy. If not I'll need to look at setting up an interim solution on my projects - not trying to pressure, I just need to plan my work.

@tonyhallett
Copy link
Collaborator

@RichardPetheram
I should be able to continue with the custom report in a week and certainly before 2 weeks time.

@AdelCaseware
Copy link

AdelCaseware commented Jun 17, 2021

@tonyhallett Any updates regarding this?

@tonyhallett
Copy link
Collaborator

On my radar. It is the next FCC task.

@tonyhallett
Copy link
Collaborator

@RichardPetheram @AdelCaseware

Latest version show branch coverage percentage column that can be sorted upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom report custom report feature
Projects
None yet
Development

No branches or pull requests

6 participants