Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this repo contain up to date code for each mainboard model? #46

Closed
imax9000 opened this issue Oct 12, 2024 · 6 comments
Closed

Does this repo contain up to date code for each mainboard model? #46

imax9000 opened this issue Oct 12, 2024 · 6 comments

Comments

@imax9000
Copy link

Looks like there almost no activity here, and no clear instructions on how to build an image for each of released mainboard models.

The reason I'm curious is that supporting MagSafe3 cables requires a slightly modified USB PD negotiation protocol (thread), meaning that one of the options is to patch EC firmware.

@DHowett
Copy link
Contributor

DHowett commented Oct 12, 2024

FWIW, I believe that you would need to work on the PD controllers and not necessarily the EC.

This repository contains up-to-date source for each program, yes.

Here are the branches:

  • fwk-marigold-22606 - Intel Core Ultra 1 13
  • lotus-zephyr - AMD 7xxx, both sizes
  • hx20-hx30 - Intel 11th, 12th and 13th Gen

@imax9000
Copy link
Author

WDYM by "PD controller" specifically?

@DHowett
Copy link
Contributor

DHowett commented Oct 12, 2024

There are two Cypress/Infineon CCG5 chips in each laptop1 in charge of USB C PD negotiation. They have their own independent firmware. I do not know if they are also the type-c port controllers or managers.

It is my understanding that the EC is not in charge of type-C negotiation in these devices.

Footnotes

  1. Well, I can't speak to the Laptop 16, but I can for the 13

@imax9000
Copy link
Author

Do you have any details on how does EC interact with them?

@imax9000
Copy link
Author

(also, can you please follow @[email protected] from your mastodon account, so I can follow you from Bluesky?)

@imax9000
Copy link
Author

https://github.com/FrameworkComputer/EmbeddedController/blob/lotus-zephyr/zephyr/program/lotus/src/cypress_pd_common.c looks like a good starting point. Sadly, public documentation on CYPD8225 leaves a lot to be desired, and it'll take a while for me to figure out if it runs SinkPPSPeriodicTimer on its own and if it does - how to configure it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants