Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up api.py file #13

Open
LexABzH opened this issue Sep 26, 2022 · 0 comments
Open

Clean up api.py file #13

LexABzH opened this issue Sep 26, 2022 · 0 comments
Labels
3 - Quality of Life Not a priority enhancement New feature or request

Comments

@LexABzH
Copy link
Collaborator

LexABzH commented Sep 26, 2022

Problem

This file includes unused stuff (such as the PreProcessor class) that we can probably remove.
We also can improve preprocess_pipeline. Maybe split by type of input data to make it clearer ?
Also, DEFAULT_PIPELINE should probably be changed to something simpler.

Solution

  • Get rid of unused stuff.
  • Make preprocess_pipeline clearer
  • Change DEFAULT_PIPELINE to something simpler.

Additional context

Adapt tests !

@LexABzH LexABzH added enhancement New feature or request 3 - Quality of Life Not a priority labels Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Quality of Life Not a priority enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant