-
Notifications
You must be signed in to change notification settings - Fork 1
Description
Right now you can add +prop
or +flow
and their optional emoji +prop=fire
to the trigger string to make a trigger prop/flow.
I'm not happy with this solution because there is a lot of string parsing and replace needing to be done and feel like there's just too much margin for error there so I want to replace it with a command function that will update a property of the trigger in the db.
proposal:
!propify <trigger_name> [optional emoji]
!flowify <trigger_name> [optional emoji]
This will update a property in the trigger object:
{
// ...
givesProp: Boolean,
propEmoji: String,
givesFlow: Boolean,
flowEmoji: String,
// ...
}
propEmoji
and flowEmoji
are optional. If the property doesn't exist or the value is null|undefined
then a default emoji will be used which are: ✊ and 🏄
This means a refactor of a few areas and the addition of 2 new commands. Off the top of my head:
- replace the check for
+prop|flow
here with a new check of the property - update triggerPoint util
- will have to write a one time script that will go through the entire database and remove all of the existing
+prop|flow
and create the new fields in the database