Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customizable END_PRINT, similar to START_PRINT #583

Open
teookie opened this issue Apr 24, 2024 · 10 comments
Open

customizable END_PRINT, similar to START_PRINT #583

teookie opened this issue Apr 24, 2024 · 10 comments
Labels
enhancement New feature or request question Further information is requested stale Issue that appear to be inactive, mark for potenial closing if stale for longer time

Comments

@teookie
Copy link

teookie commented Apr 24, 2024

Describe the feature or hardware support you'd like

Would be great if custom modules could be called in the end_print macro.

Additional context or information

No response

@teookie teookie added enhancement New feature or request triage This is a new issue to be sorted (automatic label) labels Apr 24, 2024
@Surion79
Copy link
Collaborator

Surion79 commented May 9, 2024

how many would you like and where should they be placed? It is a bit more than just adding some custom calls. it would require some sort of endprint_actions like for start print

@Surion79 Surion79 added question Further information is requested and removed triage This is a new issue to be sorted (automatic label) labels May 9, 2024
Copy link

github-actions bot commented Jun 9, 2024

📌 This issue has been marked as stale because it has not had activity in the past 30 days.
To keep it open, please respond to this message or add new information. Otherwise, this will be closed in 14 days.
Thank you for your contributions!

@github-actions github-actions bot added the stale Issue that appear to be inactive, mark for potenial closing if stale for longer time label Jun 9, 2024
@Surion79 Surion79 removed the stale Issue that appear to be inactive, mark for potenial closing if stale for longer time label Jun 21, 2024
@Surion79
Copy link
Collaborator

@Frix-x is there a need for this? it seems a bit like a bigger implementation

@rajenki
Copy link

rajenki commented Jul 16, 2024

@Surion79 I'd love this as well. 3 custom actions for end and cancel print seems great, similar to start print (including endprint_actions/cancelprint_actions).

@Surion79
Copy link
Collaborator

before implementing something like that I require more input:
which macro commands in endprint should be put in which submodules for endprint?
it needs to be divided sufficiently so stuff can be excluded by being removed from endprint_actions.

@rajenki
Copy link

rajenki commented Jul 16, 2024

I'm relatively new to Klippain still, so I'm probably not the best person to advise, but if you're asking how to break up the end/cancel print macros, I'd say the existing blocks (retract, turn off heaters, tach check, mesh clear, disable motors, filter, lights, reset filament sensor) would be a good start?

@jonathandann
Copy link

I'd like to be able to customise a (safe) x_y_z travel (including speed) so the toolhead can move away quickly from the park to avoid stringing. Similar to the move defined in https://github.com/VoronDesign/Voron-2/blob/Voron2.4/firmware/klipper_configurations/SKR_1.4/Voron2_SKR_14_Config.cfg#L574

This might workable enough as some variables, instead of a full-blown action as in print_start.

Copy link

📌 This issue has been marked as stale because it has not had activity in the past 30 days.
To keep it open, please respond to this message or add new information. Otherwise, this will be closed in 14 days.
Thank you for your contributions!

@github-actions github-actions bot added the stale Issue that appear to be inactive, mark for potenial closing if stale for longer time label Aug 30, 2024
@LuisWinter
Copy link

I would like something like this as well, or alternatively, have skew profiles in the base macro.

@github-actions github-actions bot removed the stale Issue that appear to be inactive, mark for potenial closing if stale for longer time label Sep 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

📌 This issue has been marked as stale because it has not had activity in the past 30 days.
To keep it open, please respond to this message or add new information. Otherwise, this will be closed in 14 days.
Thank you for your contributions!

@github-actions github-actions bot added the stale Issue that appear to be inactive, mark for potenial closing if stale for longer time label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested stale Issue that appear to be inactive, mark for potenial closing if stale for longer time
Projects
None yet
Development

No branches or pull requests

5 participants