Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe fuel-core block producer uses incorrect TAI time #2338

Closed
xgreenx opened this issue Oct 12, 2024 · 2 comments · Fixed by #2409
Closed

Maybe fuel-core block producer uses incorrect TAI time #2338

xgreenx opened this issue Oct 12, 2024 · 2 comments · Fixed by #2409
Assignees
@AurelienFT

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Oct 12, 2024

The library that we are using doing (10 + (1 << 62)), while wikipedia says (37 + (1 << 62)). We need to investigate this question

image
@rymnc
Copy link
Member

rymnc commented Oct 12, 2024

RustCrypto/formats#675

@AurelienFT AurelienFT assigned AurelienFT and unassigned AurelienFT Oct 22, 2024
@AurelienFT
Copy link
Contributor

PR on Tai crate : RustCrypto/formats#1583

@AurelienFT AurelienFT mentioned this issue Oct 30, 2024
Merged
5 tasks
@xgreenx xgreenx linked a pull request Oct 30, 2024 that will close this issue
Update tai64 to fix the wrong time offset #2409
Merged
5 tasks
AurelienFT added a commit that referenced this issue Oct 30, 2024
@AurelienFT
Update tai64 to fix the wrong time offset (#2409)
c72afba 
## Linked Issues/PRs
#2338
RustCrypto/formats#1583
RustCrypto/formats#1590

## Description
I have fixed the wrong offset and added an automation for future update
in crate `tai64`(RustCrypto/formats#1583) and
they merged it and made a new release
(RustCrypto/formats#1590). This PR updates to
the new version.

## Checklist
- [x] Breaking changes are clearly marked as such in the PR description
and changelog
- [x] New behavior is reflected in tests
- [x] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [x] I have reviewed the code myself
- [x] I have created follow-up issues caused by this PR and linked them
here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AurelienFT AurelienFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update tai64 to fix the wrong time offset FuelLabs/fuel-core
3 participants
@xgreenx @AurelienFT @rymnc