Skip to content

Commit f7f0f0a

Browse files
fix: s3 publishing (#3643)
* fix: s3 publishing * fix: changeset * Update .changeset/plenty-beds-bake.md --------- Co-authored-by: Anderson Arboleya <[email protected]>
1 parent 18bdae8 commit f7f0f0a

File tree

7 files changed

+18
-15
lines changed

7 files changed

+18
-15
lines changed

.changeset/plenty-beds-bake.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@fuel-ts/account": patch
3+
---
4+
5+
fix: s3 publishing

.github/workflows/release.yaml

+5-7
Original file line numberDiff line numberDiff line change
@@ -166,19 +166,17 @@ jobs:
166166
rootdir: ""
167167
workdir: ""
168168

169-
- uses: aws-actions/configure-aws-credentials@v4
169+
- name: Configure AWS credentials
170+
uses: aws-actions/configure-aws-credentials@v4
170171
if: github.ref_name == 'master' && steps.changesets.outputs.published != 'true'
171172
with:
172-
aws-access-key-id: ${{ secrets.S3_CDN_ACCESS_KEY }}
173-
aws-secret-access-key: ${{ secrets.S3_CDN_SECRET_KEY }}
174-
aws-region: us-east-1
173+
role-to-assume: ${{ env.AWS_ROLE_ARN }}
174+
aws-region: ${{ env.AWS_S3_REGION }}
175175

176176
- name: Upload assets to s3
177177
if: github.ref_name == 'master' && steps.changesets.outputs.published != 'true'
178178
run: |
179-
aws s3 cp ./packages/account/src/providers/assets/images/ s3://${S3_CDN_BUCKET}/assets/ --recursive
180-
env:
181-
S3_CDN_BUCKET: ${{ secrets.S3_CDN_BUCKET }}
179+
aws s3 cp ./packages/account/src/providers/assets/images/ s3://${{ env.AWS_S3_BUCKET }}/providers/ --recursive
182180
183181
# # Commenting out as we require permissions to trigger across repos
184182
# - name: Notify migrations and disclosures of the new release (breaking changes)

apps/docs/src/guide/wallets/snippets/connectors.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ class WalletConnector extends FuelConnector {
9999
{
100100
name: 'Ethereum',
101101
symbol: 'ETH',
102-
icon: 'https://cdn.fuel.network/assets/eth.svg',
102+
icon: 'https://assets.fuel.network/providers/eth.svg',
103103
networks: [
104104
{
105105
type: 'ethereum',

packages/account/src/providers/assets/assets.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ describe('assets', async () => {
1010
});
1111

1212
it.each(assets)('$symbol should have icon resolved to URL', async ({ icon }) => {
13-
expect(icon).toContain('https://cdn.fuel.network/assets');
13+
expect(icon).toContain('https://assets.fuel.network/providers');
1414
});
1515
});
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export const fuelAssetsBaseUrl = 'https://cdn.fuel.network/assets/'
1+
export const fuelAssetsBaseUrl = 'https://assets.fuel.network/providers/'

packages/account/src/providers/assets/utils/network.test.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ describe('Network Utils', () => {
1919
type: 'ethereum',
2020
chainId: CHAIN_IDS.eth.sepolia,
2121
decimals: 18,
22-
icon: 'https://cdn.fuel.network/assets/eth.svg',
22+
icon: 'https://assets.fuel.network/providers/eth.svg',
2323
name: 'Ethereum',
2424
symbol: 'ETH'
2525
})
@@ -33,7 +33,7 @@ describe('Network Utils', () => {
3333
chainId: CHAIN_IDS.fuel.testnet,
3434
decimals: 9,
3535
assetId: '0xf8f8b6283d7fa5b672b530cbb84fcccb4ff8dc40f8176ef4544ddb1f1952ad07',
36-
icon: 'https://cdn.fuel.network/assets/eth.svg',
36+
icon: 'https://assets.fuel.network/providers/eth.svg',
3737
name: 'Ethereum',
3838
symbol: 'ETH'
3939
})
@@ -52,7 +52,7 @@ describe('Network Utils', () => {
5252
type: 'ethereum',
5353
chainId: CHAIN_IDS.eth.sepolia,
5454
decimals: 18,
55-
icon: 'https://cdn.fuel.network/assets/eth.svg',
55+
icon: 'https://assets.fuel.network/providers/eth.svg',
5656
name: 'Ethereum',
5757
symbol: 'ETH',
5858
})
@@ -67,7 +67,7 @@ describe('Network Utils', () => {
6767
chainId: CHAIN_IDS.fuel.testnet,
6868
decimals: 9,
6969
assetId: '0xf8f8b6283d7fa5b672b530cbb84fcccb4ff8dc40f8176ef4544ddb1f1952ad07',
70-
icon: 'https://cdn.fuel.network/assets/eth.svg',
70+
icon: 'https://assets.fuel.network/providers/eth.svg',
7171
name: 'Ethereum',
7272
symbol: 'ETH',
7373
})

packages/fuel-gauge/src/e2e-script.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ describe.each(selectedNetworks)('Live Script Test', (selectedNetwork) => {
219219
const expectedBaseAsset = [
220220
{
221221
...expectedRawBaseAsset[0],
222-
icon: 'https://cdn.fuel.network/assets/eth.svg',
222+
icon: 'https://assets.fuel.network/providers/eth.svg',
223223
},
224224
];
225225

0 commit comments

Comments
 (0)