Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initialization parameters for Brush class and Add check validation #10

Open
G2Pavon opened this issue Jan 18, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@G2Pavon
Copy link
Owner

G2Pavon commented Jan 18, 2024

Change the initialization from Brush.__init__(self) to Brush.__init__(self, faces).

Check if the given faces create a valid brush:

  • len(faces) >= 4
  • not infinitely large
  • not empty
@G2Pavon G2Pavon added the enhancement New feature or request label Jan 18, 2024
@G2Pavon
Copy link
Owner Author

G2Pavon commented Jan 20, 2024

Initialization parameter was added, but they are not required. Added brush valid verification if len(faces) >= 4. 1b091cb

TODO:

  • make parameter required (Requirements: Refactor load_map())
  • check if brush is infinetely large

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant