-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reviewed] Add AdvancedHTTP extension #941
Conversation
I was thinking that people would be able to use my already existing URL Tools extension to mutate the URL query string parameters and that it would be a bit out of scope to reimplement all the URL mutating work in this extension. |
@arthuro555 can you provide an example project that I can use for testing? |
Do you want to go for community while a review is on going? |
I'm good, I'll wait for the review 👍 I'd rather keep the flexibility of being able to have breaking changes if the review requires some. |
@tristanbob Here's the example I used in the screenshot: Fetch.zip I believe I used all conditions, expressions and actions in there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed this extension and chatted with @arthuro555 about it.
The concerns I had were:
-
If CORS bypass is enabled, requests go through a middle server (by design) and could be a privacy issue. I think this concern is addressed by the text in the "Enable CORS bypass" action, and that CORS bypass is opt-in (not enabled by default).
-
If CORS bypass is enabled and the service goes down, it could cause an outage for games. This scenario is unlikely since the service is provided by Cloudflare workers.
Thanks @arthuro555 for once again providing high-quality power tools for advanced GDevleop users!
Co-authored-by: Tristan Rhodes <[email protected]>
An advanced HTTP client with supports for headers, cache control, built-in opt-in CORS proxy (hosted on the edge via Cloudflare Workers).
Everything has been thoroughly tested via a mock server.
All events can be seen in this example screenshot: