Skip to content

Classifier gives inconsistent classifications #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kirstybayliss opened this issue Sep 30, 2024 · 0 comments · May be fixed by #469
Open

Classifier gives inconsistent classifications #434

kirstybayliss opened this issue Sep 30, 2024 · 0 comments · May be fixed by #469

Comments

@kirstybayliss
Copy link
Contributor

kirstybayliss commented Sep 30, 2024

The classifier sometimes gives inconsistent event classifications. The profile_workflow_classification test highlighted this, passing locally and in the github CI checks but failing elsewhere. For Chris (on windows), there are 12 events (in ~4600) that switch between 'slab' and 'unknown':
image

Reducing the test data to exclude these mismatching events still results in a failure for Michele (but not locally for me or Chris, or in the CI).
Michele has suggested this might be due to floating point rounding, which is often machine dependent. Either way, we should add more tests to the classification step. In the meantime, the profile_workflow_classification test is skipped.

The original classification (for me) and Chris's classifications are in the csv, it might be useful to compare with any other classification outputs people get.

classified_earthquakes_test_orig.csv

@kirstybayliss kirstybayliss linked a pull request Apr 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant