Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retention "till" #144

Open
TFiFiE opened this issue Jan 10, 2020 · 1 comment
Open

Retention "till" #144

TFiFiE opened this issue Jan 10, 2020 · 1 comment
Assignees
@elv1s42
Labels
enhancement

Comments

@TFiFiE
Copy link

TFiFiE commented Jan 10, 2020

The till setting is misleadingly named, because being under retention, it would imply that test runs up to the given time are retained rather than deleted or that test runs are kept until that point in time is reached. since (or similar) would be a much more logical choice and would also be consistent with amount by having the phrasing be in terms of what is kept. Examples where this has tripped up people:
GHPReporter/Ghpr.MSTest#23 (comment)
GHPReporter/Ghpr.Console#43 (comment)
@elv1s42 elv1s42 self-assigned this Mar 18, 2020
@elv1s42
Copy link
Member

elv1s42 commented Mar 18, 2020

Thank you for the issue!

I agree this makes sense, going to fix the naming.
The since name looks like a good one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elv1s42 elv1s42

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elv1s42 @TFiFiE