Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive use of nan/infinity/max #1147

Open
mglisse opened this issue Oct 19, 2024 · 0 comments
Open

Excessive use of nan/infinity/max #1147

mglisse opened this issue Oct 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mglisse
Copy link
Member

mglisse commented Oct 19, 2024

(generalization of #413)
There are a lot of places where we rely on the type (filtration value, coordinate, etc) supporting NaN, infinity and/or max. However, there are perfectly sensible types that do not support any of those (think BigInteger). Using the special values is convenient, but we should see if there are places where we could avoid using them without penalizing double too much (speed + code readability).

@mglisse mglisse added the enhancement New feature or request label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant