Skip to content

Support GHC 9.10.1, drop 9.4.5 #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

Support GHC 9.10.1, drop 9.4.5 #285

merged 1 commit into from
Jul 1, 2025

Conversation

langston-barrett
Copy link
Contributor

Fixes #283

@langston-barrett langston-barrett self-assigned this Feb 14, 2025
@langston-barrett langston-barrett force-pushed the lb/ghc-9.10 branch 2 times, most recently from 037209c to 7ac2f54 Compare February 14, 2025 16:27
@langston-barrett
Copy link
Contributor Author

Hmm, not sure what to do about this Nix failure.

code-page> Running phase: checkPhase
code-page> Error: [Cabal-8123]
code-page> Use of GHC's environment variable GHC_PACKAGE_PATH is incompatible with Cabal. Use the flag --package-db to specify a package database (it can be used multiple times).
code-page> 
error: builder for '/nix/store/b41hgzjh45xhx60qjk73vd77jclf7vi8-code-page-0.2.1.drv' failed with exit code 1;
       last 25 log lines:
       > No pkg-config found
       > Using runghc version 9.10.1 found on system at:
       > /nix/store/jmwzwqxqgxj48vkyvqb3ypkf67bpyk0r-ghc-9.10.1/bin/runghc-9.10.1
       > Using strip version 2.41 found on system at:
       > /nix/store/9bv7dcvmfcjnmg5mnqwqlq2wxfn8d7yi-gcc-wrapper-13.2.0/bin/strip
       > Using tar found on system at:
       > /nix/store/rik7p68cq7yzlj5pmfpf4yv6jnrpvlgf-gnutar-1.35/bin/tar
       > No uhc found
       > Running phase: buildPhase
       > Preprocessing library for code-page-0.2.1...
       > Building library for code-page-0.2.1...
       > [1 of 3] Compiling System.IO.CodePage.Internal ( src/System/IO/CodePage/Internal.hs, dist/build/System/IO/CodePage/Internal.o, dist/build/System/IO/CodePage/Internal.dyn_o )
       > [2 of 3] Compiling System.IO.CodePage ( src/System/IO/CodePage.hs, dist/build/System/IO/CodePage.o, dist/build/System/IO/CodePage.dyn_o )
       > [3 of 3] Compiling System.Win32.CodePage ( dist/build/System/Win32/CodePage.hs, dist/build/System/Win32/CodePage.o, dist/build/System/Win32/CodePage.dyn_o )
       > [1 of 3] Compiling System.IO.CodePage.Internal ( src/System/IO/CodePage/Internal.hs, dist/build/System/IO/CodePage/Internal.p_o )
       > [2 of 3] Compiling System.IO.CodePage ( src/System/IO/CodePage.hs, dist/build/System/IO/CodePage.p_o )
       > [3 of 3] Compiling System.Win32.CodePage ( dist/build/System/Win32/CodePage.hs, dist/build/System/Win32/CodePage.p_o )
       > Preprocessing test suite 'tests' for code-page-0.2.1...
       > Building test suite 'tests' for code-page-0.2.1...
       > [1 of 1] Compiling Main             ( tests/Tests.hs, dist/build/tests/tests-tmp/Main.o )
       > [2 of 2] Linking dist/build/tests/tests
       > Running phase: checkPhase
       > Error: [Cabal-8123]
       > Use of GHC's environment variable GHC_PACKAGE_PATH is incompatible with Cabal. Use the flag --package-db to specify a package database (it can be used multiple times).
       >
       For full logs, run:
         nix log /nix/store/b41hgzjh45xhx60qjk73vd77jclf7vi8-code-page-0.2.1.drv
error: 1 dependencies of derivation '/nix/store/xalhz9q992nh49kmb3zj0cpigy53mj8n-doctest-0.22.2.drv' failed to build

@kquick Any ideas? I ran nix flake update and tried to duplicate what I saw for GHC 8 for GHC 9...

As an aside, it might be nice to add some documentation to doc/developing.md on how to perform a GHC version upgrade for the flake - I personally don't feel confident doing it, and this is (I believe) one of our few packages in the verification/binary analysis ecosystem that provides one.

@RyanGlScott
Copy link
Contributor

If you do document how to update the flake, please make sure to close #276 afterwards.

Do not update Nix flake or CI, due to unresolved difficulties.
@langston-barrett
Copy link
Contributor Author

langston-barrett commented Jun 4, 2025

We may want to consider moving forward with this without fixing the Nix issues. I don't think they are a critical blocker, because the Nix build and CI process appears entirely parallel to the normal one. Accordingly, I've reverted my changes to the Nix builds.

EDIT: If we decide to go this route, I'll create a follow-up issue before merging.

@langston-barrett langston-barrett marked this pull request as ready for review June 4, 2025 22:05
@sauclovian-g
Copy link
Contributor

This should probably get merged before the next release cycle, which is probably something we should be starting to think about...

@langston-barrett langston-barrett merged commit 4297edf into master Jul 1, 2025
26 checks passed
@langston-barrett langston-barrett deleted the lb/ghc-9.10 branch July 1, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GHC 9.10
3 participants