Support function pointer alignment in data layouts #298
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
added a commit
to GaloisInc/crucible
that referenced
this pull request
Jul 19, 2025
This bumps the following submodules to bring in changes necessary to support function pointer alignment in data layouts: * `llvm-pretty`: GaloisInc/llvm-pretty#163 * `llvm-pretty-bc-parser: GaloisInc/llvm-pretty-bc-parser#298 It also adjusts the data layout-parsing code in `crucible-llvm` accordingly. For now, the only meaningful use of function pointer alignment in `crucible-llvm` is in computing the `maxAlignment`. See GaloisInc/llvm-pretty-bc-parser#292 for the parent issue involving function pointer alignment in data layouts.
This bumps the `llvm-pretty` submodule to bring in the changes from GaloisInc/llvm-pretty#163, which allows `llvm-pretty-bc-parser` to support parsing function pointer alignment in data layouts (e.g., `Fn32`). This also adds a regression test. Fixes #292.
RyanGlScott
force-pushed
the
T292-DataLayout-function-pointer-alignment
branch
from
19bd898 to
06e879c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the
llvm-prettysubmodule to bring in the changes from GaloisInc/llvm-pretty#163, which allowsllvm-pretty-bc-parserto support parsing function pointer alignment in data layouts (e.g.,Fn32). This also adds a regression test.Fixes #292.
Marked as a draft pending GaloisInc/llvm-pretty#163 (on which this PR depends) landing upstream.