Prepare release 1.7.0 #293
Conversation
|
Question: should the version number be 1.7.0.0 or 1.7.0 or 1.7? Everything else seems to use 4-part version numbers but the older releases are all two or three parts... |
|
In the absence of actual documentation, let's stay consistent with current practice and use three parts. |
| @@ -20,7 +20,7 @@ common dependencies | |||
| , lens | |||
| , parameterized-utils >=2.0 && <2.2 | |||
| , text | |||
| , what4 ^>=1.6 | |||
| , what4 >=1.6 && <1.8 | |||
There was a problem hiding this comment.
We may as well use what4 ^>=1.7 here, for reasons similar to GaloisInc/llvm-pretty-bc-parser#291 (comment).
(More generally, I think these version bounds aren't buying us much. We are depending on what4 directly as a subproject in the cabal.project file, so whatever version number the what4 subproject uses will effectively impose a precise version bound on what what4-transition-system uses.)
There was a problem hiding this comment.
Yeah, probably better to remove it entirely
sauclovian-g
force-pushed
the
prepare-release-1.7.0
branch
from
7b6434c to
76bed38
Compare
| -- what4 lives in the same repo; no version bound is needed | ||
| , what4 |
There was a problem hiding this comment.
You might consider factoring this out into its own commit. The same commit could also add this comment to these other .cabal files in the same repo:
what4/what4-abc/what4-abc.cabal
Line 25 in c185a55
what4/what4-blt/what4-blt.cabal
Line 32 in c185a55
These are all one repo and the other packages aren't released
separately ("not labeled for retail sale"...) so the what4 they get
will always be the current version. Replace the bound with a comment
to this effect.
Add the 1.7 release and release date to the changelog.
sauclovian-g
force-pushed
the
prepare-release-1.7.0
branch
from
76bed38 to
f5e476f
Compare
No description provided.