Skip to content

Avoid calling extrema(...; dims) with empty arrays. See PR #1711 #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

joa-quim
Copy link
Member

@joa-quim joa-quim commented May 1, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.90%. Comparing base (1f3ac2a) to head (f766ac7).

Files with missing lines Patch % Lines
src/extras/lowess.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
+ Coverage   85.75%   85.90%   +0.15%     
==========================================
  Files         167      167              
  Lines       23363    23377      +14     
==========================================
+ Hits        20034    20083      +49     
+ Misses       3329     3294      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joa-quim joa-quim merged commit b547924 into master May 1, 2025
9 of 13 checks passed
@joa-quim joa-quim deleted the avoid-call-extrema-on-empties branch May 1, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants