-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen Mirrored is Inverted #1380
Comments
Inverted how? Vertically? If you record with:
Is the video "inverted" too? |
Yes the video too is inverted
…On Mon, 11 May, 2020, 12:18 pm Romain Vimont, ***@***.***> wrote:
Inverted how? Vertically?
If you record with:
adb shell screen record /sdcard/file.mp4
adb pull /sdcard/file.mp4
Is the video "inverted" too?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1380 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APRBYVZATGC6ZBFJYD6TWD3RQ6NVLANCNFSM4M5SYUBQ>
.
|
OK, so there is a bug in your device ROM. Is it flipped vertically, or rotated 180°? If you rotate it twice with |
It is not flipped it is inverted
…On Mon, 11 May, 2020, 1:39 pm Romain Vimont, ***@***.***> wrote:
Is it flipped vertically, or rotated 180°?
If you rotate it twice with Ctrl+→ (or scrcpy --rotation 2), does it fix
the problem?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1380 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APRBYVZBHUDJLQLTEQMFU7TRQ6XFFANCNFSM4M5SYUBQ>
.
|
What do you mean by inverted, then? Cold you post a screenshot? |
Yes wait I'll email you the screenshot
…On Mon, 11 May, 2020, 1:50 pm Romain Vimont, ***@***.***> wrote:
What do you mean by inverted, then? Cold you post a screenshot?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1380 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APRBYV6H6KNDALWUVLEE4Y3RQ6YNLANCNFSM4M5SYUBQ>
.
|
Here is screenshot of how actually inverted it is.
…On Mon, 11 May, 2020, 1:54 pm MH12 l Kushhh, ***@***.***> wrote:
Yes wait I'll email you the screenshot
On Mon, 11 May, 2020, 1:50 pm Romain Vimont, ***@***.***>
wrote:
> What do you mean by inverted, then? Cold you post a screenshot?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#1380 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APRBYV6H6KNDALWUVLEE4Y3RQ6YNLANCNFSM4M5SYUBQ>
> .
>
|
You can't send it by email that way, you have to post it on the GitHub thread. |
OK so it's flipped (horizontally). This is a bug on your device, and scrcpy does not provide any option to workaround that. You could force a flip by modifying the source code and building: diff --git a/app/src/screen.c b/app/src/screen.c
index 0af8de8..14c478e 100644
--- a/app/src/screen.c
+++ b/app/src/screen.c
@@ -444,7 +444,7 @@ screen_update_frame(struct screen *screen, struct video_buffer *vb) {
void
screen_render(struct screen *screen) {
SDL_RenderClear(screen->renderer);
- if (screen->rotation == 0) {
+ if (false && screen->rotation == 0) {
SDL_RenderCopy(screen->renderer, screen->texture, NULL, NULL);
} else {
// rotation in RenderCopyEx() is clockwise, while screen->rotation is
@@ -464,7 +464,7 @@ screen_render(struct screen *screen) {
}
SDL_RenderCopyEx(screen->renderer, screen->texture, NULL, dstrect,
- angle, NULL, 0);
+ angle, NULL, SDL_FLIP_HORIZONTAL);
}
SDL_RenderPresent(screen->renderer);
} |
I have installed it using apt. I haven't built this. So in order to build where exactly can I change source code? |
I wanted to view my screen flipped for a video-recording studio. This issue has helped me instead. Going to rebuild on Windows. Where can I see what are the other options instead of |
We can keep a command-line argument for showing the flipped video (both horizontal and vertical), much like other switches. |
In case someone still needs this, here is a Windows build of the current commit on |
@rom1v The addition of a switch such as |
Build sadly doesn't work, always returns "could not execute adb push" (whereas the |
set bluestacks graphic engine mode to "Compatibility", it will show normal display then |
hey mostm, I built it as well with those changes but get error when running scrcpy (rasp pi 400, debian bullseye) ERROR: Could not initialize SDL: displayIndex must be in the range 0 - -1 were there any other changes required? or would something else be required for v1.24? |
Please test #4441. |
Implemented in v2.3. |
Environment
Describe the bug
A clear and concise description of what the bug is.
On errors, please provide the output of the console (and
adb logcat
if relevant).Please do not post screenshots of your terminal, just post the content as text instead.
When ever I screen mirror any device it gets mirror but inverted like every thing is inverted.
The text was updated successfully, but these errors were encountered: