Android 14 beta lock orientation doesn't work as expected when the device goes into landscape mode.

[ssalenik]

• I have read the FAQ.
• I have searched in existing issues.

Environment

• OS: macOS
• scrcpy version: 2.0
• installation method: brew
• device model: Pixel 7,
• Android version: Android 14 Beta (UpsideDownCake)

Describe the bug
Android 14 beta lock orientation doesn't work as expected when the device goes into landscape mode.
eg: if you launch: scrcpy --lock-video-orientation=0 then go into landscape in an app, you get this:

Looks like it no longer rotates the display output to fit the surface of the codec, but instead it keeps it in its orientation and scales it. Not clear if its a "bug" which will be fixed in the release, but seems possibly unlikely since its already in beta.

[vikingden8]

me too, I think this is a problem on new Android 14

[ssalenik]

OK, so now that the 14 source is released, I think the issue is due to this change in the SurfaceControl.setDisplayProjection fn:
Android 13: https://android.googlesource.com/platform/frameworks/base.git/+/refs/heads/android13-dev/core/java/android/view/SurfaceControl.java#2355

Android 14: https://android.googlesource.com/platform/frameworks/base.git/+/refs/tags/android-14.0.0_r2/core/java/android/view/SurfaceControl.java#2331

This fn now ignores the orientation param:

/**
--
  | * Because this API is now going through {@link DisplayManager}, orientation and displayRect
  | * will automatically be computed based on configuration changes. Because of this, the params
  | * orientation and displayRect are ignored
  | *
  | * @hide
  | */
  ```

[rom1v]

@ssalenik Thank you 👍

Reported here.

[ssalenik]

Thanks. I think it may be possible to find a work around by re-implementing this public static VirtualDisplay createVirtualDisplay fn here:
https://android.googlesource.com/platform/frameworks/base.git/+/refs/tags/android-14.0.0_r2/core/java/android/hardware/display/DisplayManager.java#1567

which is what is called by SurfaceControl.createDisplay fn here:
https://android.googlesource.com/platform/frameworks/base.git/+/refs/tags/android-14.0.0_r2/core/java/android/view/SurfaceControl.java#2385

And possibly adding this hidden display flag VIRTUAL_DISPLAY_FLAG_ROTATES_WITH_CONTENT: https://android.googlesource.com/platform/frameworks/base.git/+/refs/tags/android-14.0.0_r2/core/java/android/hardware/display/DisplayManager.java#372

To the VirtualDisplayConfig here:
https://android.googlesource.com/platform/frameworks/base.git/+/refs/tags/android-14.0.0_r2/core/java/android/hardware/display/DisplayManager.java#1577

I've used this hidden flag before with the MediaProjection api to accomplish the same thing.

[ssalenik]

FYI, I tried doing what I suggested above, but it didn't work.
I was able to re-implement the public static VirtualDisplay createVirtualDisplay fn in DisplayManager and add passing the VIRTUAL_DISPLAY_FLAG_ROTATES_WITH_CONTENT flag to the VirtualDisplayConfig, but it did not change the behaviour.